Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the login overwriting test #12507

Merged
merged 1 commit into from May 14, 2024
Merged

Disable the login overwriting test #12507

merged 1 commit into from May 14, 2024
+3 −1

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented May 8, 2024

See conmment

Fixes element-hq/element-web#27363

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@dbkr dbkr added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 8, 2024
@dbkr dbkr marked this pull request as ready for review May 8, 2024 16:57
@dbkr dbkr requested a review from a team as a code owner May 8, 2024 16:57
@dbkr dbkr requested review from t3chguy and robintown May 8, 2024 16:57
@t3chguy t3chguy mentioned this pull request May 10, 2024
Merged
@t3chguy t3chguy reopened this May 13, 2024
@t3chguy t3chguy enabled auto-merge May 13, 2024 22:59
@t3chguy t3chguy added this pull request to the merge queue May 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2024
@t3chguy t3chguy added this pull request to the merge queue May 14, 2024
Merged via the queue into develop with commit 7a4ac57 May 14, 2024
57 checks passed
@t3chguy t3chguy deleted the dbkr/disable_overwrite_test branch May 14, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky playwright test: login/overwrite_login.spec.ts: Try replace existing login with new one
2 participants
@dbkr @t3chguy