Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flakiness in playwright tests #12512

Merged
merged 9 commits into from May 13, 2024
Merged

Fix flakiness in playwright tests #12512

merged 9 commits into from May 13, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 10, 2024 •
edited

Closes #12507

@t3chguy
Remove redundant option
f5d6689 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Stabilise app download dialog screenshot test
324a81c 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Try to stabilise user menu opening in playwright tests
f0fb0b5 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Stabilise one-to-one-chat.spec.ts
98b6ac3 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Stabilise kick.spec.ts
171c0ac 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 10, 2024
@t3chguy
Iterate
80f869a 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy marked this pull request as ready for review May 10, 2024 12:05
@t3chguy t3chguy requested a review from a team as a code owner May 10, 2024 12:05
@t3chguy t3chguy self-assigned this May 10, 2024
@richvdh richvdh changed the title Stabilise playwright tests Fix flakiness in playwright tests May 13, 2024
@richvdh
Copy link
Member

richvdh commented May 13, 2024

For me, "stabilise" means something like "take out of beta"/"declare this to be a 'stable' feature". Have tweaked title accordingly.

richvdh
richvdh reviewed May 13, 2024
View reviewed changes
playwright/element-web-test.ts Outdated Show resolved Hide resolved
playwright/pages/settings.ts Outdated Show resolved Hide resolved
playwright/e2e/one-to-one-chat/one-to-one-chat.spec.ts Show resolved Hide resolved
@t3chguy t3chguy requested a review from richvdh May 13, 2024 12:38
@t3chguy t3chguy added this pull request to the merge queue May 13, 2024
Merged via the queue into develop with commit b283b18 May 13, 2024
30 checks passed
@t3chguy t3chguy deleted the t3chguy/stabilise-playwright branch May 13, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@t3chguy @richvdh