Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Implement MSC4142: Remove unintentional intentional mentions in replies #12511

Closed

Conversation

tulir
Copy link
Member

@tulir tulir commented May 9, 2024

Signed-off-by: Tulir Asokan <tulir@maunium.net>
@tulir
Copy link
Member Author

tulir commented May 11, 2024

The MSC requires an opinion from product-centered folks, so marking this as ready for review. The current spec is just a recommendation, so following it is not required and this can be merged already before the MSC is accepted. The goal of the MSC is to remove the dumb recommendation from the spec

For context:

  • Old behavior before intentional mentions: reply fallbacks caused replies to mention the sender of the replied-to message, as well as any users explicitly mentioned in the replied-to message
  • Current behavior in Element: replies mention the sender of the replied-to message, as well as all users explicitly or implicitly mentioned in the replied-to message. Implicit mentions includes any mentions from earlier in the reply chain (like the senders of all previous messages and any users ever mentioned in the chain)
  • New behavior after this PR: replies mention the sender of the replied-to message

In all cases, new explicit mentions are also of course included

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mentioned by reply to message that mentioned me
2 participants