This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix autocomplete #2212
Merged
Fix autocomplete #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been commented out for ages. Just remove it and make things use QueryMatcher directly rather than looking like they do fuzzy matching but not.
This rewrites quite a lot of QueryMatcher. * Remove FuzzyMatcher which was a whole file of commented out code that just deferred to QueryMatcher * Simplify & remove some cruft from QueryMatcher, eg. most of the KeyMap stuff was completely unused. * Don't rely on object iteration order, which fixes a bug where users whose display names were entirely numeric would always appear first... * Add options.funcs to QueryMatcher to allow for indexing by things other than keys on the objects * Use above to index users by username minus the leading '@' * Don't include the '@' in the query when autocomple is triggered by typing '@'. Fixes element-hq/element-web#6782
Which 1) has a fairly complex interface with lots of subtleties and 2) is really trivial to unit test.
turt2live
approved these changes
Oct 12, 2018
| this.matcher = new FuzzyMatcher([], { | ||
| keys: ['name', 'userId'], | ||
| this.matcher = new QueryMatcher([], { | ||
| keys: ['name'], |
There was a problem hiding this comment.
do we not want to keep userId here?
There was a problem hiding this comment.
or something to match the localpart, at least
There was a problem hiding this comment.
It's done below with a function to chop off the leading '@'
bwindels
approved these changes
Oct 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites quite a lot of QueryMatcher.
Fixes element-hq/element-web#6782