This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Token encouragement if zxcvbn gives no feedback #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxcvbn is hardcoded to give no suggedtions if the score is greater than 2, but our threshold is 4, so give some generic feedback. Fixes element-hq/element-web#7860
jryans
approved these changes
Jan 21, 2019
| @@ -254,7 +254,7 @@ export default React.createClass({ | |||
| } | |||
| const suggestionBlock = suggestions.length > 0 ? <div> | |||
| {suggestions} | |||
| </div> : null; | |||
| </div> : <div>{_t("Keep going...")}</div>; | |||
There was a problem hiding this comment.
Maybe move the ternary inside the <div>s to avoid the repetition?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zxcvbn is hardcoded to give no suggedtions if the score is greater
than 2, but our threshold is 4, so give some generic feedback.
Fixes element-hq/element-web#7860