This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Move non-feather icons out of feather dir #2706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They appear to all be created by Nad, according to matrix-org#2557.
These clearly aren't from the Feather set.
|
Hmm, we could name the remaining Feather-like ones something like |
Yeah, any of those sound good to me. |
|
Ah, I guess it should be |
These icons are based on Feather as the original source, but they have various tweaks applied, such as stroke width, color, etc. Hopefully the tweaked name makes this more obvious in the future.
bwindels
approved these changes
Feb 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, most icons in
feather-iconsdo actually match the Feather set, but they have different names and the source is entirely different as they've been styled by intermediate tools like Sketch. For those, it seems logical to stay infeather-iconsas long as the lines that make up the icon match something in the Feather set. (I verified this by visual inspection.)This PR moves the remaining few icons which are clearly not part of Feather. The was one name clash on
lock-warning, so I tweaked the name of one of those tolock-warning-filled.Fixes element-hq/element-web#8348