This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Prevent flair pushing timeline downwards #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so it doesn't push the message down
jryans
approved these changes
Mar 5, 2019
| @@ -117,7 +117,7 @@ export default class Flair extends React.Component { | |||
|
|
|||
| render() { | |||
| if (this.state.profiles.length === 0) { | |||
| return <div />; | |||
There was a problem hiding this comment.
Huh, surprised it used to switch to a div when empty... Anyway, now it's fixed!
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flair badges in the timeline make the sender part of an event tile taller, which AFAIK doesn't serve an aesthetical purpose, and makes it harder to keep the scroll position bottom aligned.
In case something regresses with the styling, we still set .mx_Flair on the container even though there are not profiles to render so the size can't change.
Here's toggling
display: noneon the.mx_Flair:It looks like this fixes element-hq/element-web#9018 & element-hq/element-web#8792