Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm audit fix --force #2758

Merged
merged 1 commit into from Mar 6, 2019
Merged

npm audit fix --force #2758

merged 1 commit into from Mar 6, 2019

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Mar 6, 2019

Doesn't appear to break anything...

Doesn't appear to break anything...
@dbkr dbkr changed the title npnm audit --fix --force npm audit --fix --force Mar 6, 2019
@dbkr dbkr changed the title npm audit --fix --force npm audit fix --force Mar 6, 2019
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks! 😁

I guess Karma 4 does drop Node 6, but we already say you need at least Node 8.

@dbkr dbkr merged commit aebdff7 into develop Mar 6, 2019
@jryans
Copy link
Collaborator

jryans commented Mar 6, 2019

chokidar 2 changes globbing to be more strict... Looks like our only usage of it should be fine, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants