Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IS access token callback #3337

Merged
merged 2 commits into from Aug 23, 2019
Merged

Add IS access token callback #3337

merged 2 commits into from Aug 23, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Aug 22, 2019

This passes a callback to the JS SDK which it can use to get IS access tokens
whenever needed for either talking to the IS directly or passing along to the
HS.

Fixes element-hq/element-web#10525
Depends on matrix-org/matrix-js-sdk#1022

This passes a callback to the JS SDK which it can use to get IS access tokens
whenever needed for either talking to the IS directly or passing along to the
HS.

Fixes element-hq/element-web#10525
@jryans jryans requested a review from a team August 22, 2019 13:48
@turt2live turt2live requested review from turt2live and removed request for a team August 22, 2019 14:43
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code looks fine - I have thoughts on the other side though

@jryans jryans requested a review from turt2live August 23, 2019 10:18
@jryans jryans merged commit 47ee299 into develop Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IS interactions proxied through the HS also need terms agreement
2 participants