Send id_access_token to HS for use in proxied IS requests #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This passes along the `id_access_token` to the HS, which it will need when speaking v2 IS APIs to the IS. Unfortunately, some HSes seem to explode when given this new parameter, so we only pass it along for the moment if an unstable feature `m.id_access_token` is also set. Part of element-hq/element-web#10525 Defined in MSC2140
turt2live
requested changes
Aug 22, 2019
turt2live
approved these changes
Aug 23, 2019
manuroe
added a commit
to matrix-org/matrix-ios-sdk
that referenced
this pull request
Aug 29, 2019
…rverAcceptIdentityAccessToken properties. As implemented in matrix-org/matrix-js-sdk#1018 and matrix-org/matrix-js-sdk#1022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes along the
id_access_tokento the HS, which it will need whenspeaking v2 IS APIs to the IS.
Unfortunately, some HSes seem to explode when given this new parameter, so we
only pass it along for the moment if an unstable feature
m.id_access_tokenisalso set.
Part of element-hq/element-web#10525
Used by matrix-org/matrix-react-sdk#3337
Defined in MSC2140