Show incoming verification requests in in-app notifications #3661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwindels
force-pushed
the
bwindels/verif-toasts
branch
from
efabfb5
to
0f3d43e
Compare
might merge it later on with accessible button
as it is very light otherwise
bwindels
force-pushed
the
bwindels/verif-toasts
branch
from
0f3d43e
to
20a1a5e
Compare
this uses a verification requests as emitted by the js-sdk with the `crypto.verification.request` rather than a verifier as emitted by `crypto.verification.start` as this works for both to_device and timeline events with the changes made in the js-sdk pr.
bwindels
force-pushed
the
bwindels/verif-toasts
branch
from
20a1a5e
to
8cb3620
Compare
dbkr
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: element-hq/element-web#11223
Requires: matrix-org/matrix-js-sdk#1085