Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix /op Slash Command #4604

Merged
merged 4 commits into from
Jul 16, 2020
Merged

Fix /op Slash Command #4604

merged 4 commits into from
Jul 16, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 18, 2020 •
edited
Loading

Fixes element-hq/element-web#13697
Fixes element-hq/element-web#12527

Only allows /oping of users which are invited/joined to the room.

@t3chguy
Fix /op Slash Command
6eee39c 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
make test more specific
b4e2e54 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from a team May 18, 2020 11:06
@aaronraimist
Copy link
Contributor

I don't understand why you shouldn't be able to set the power level of someone who isn't in the room yet. I guess this is intending to fix element-hq/element-web#12527 but I agree with element-hq/element-web#12527 (comment).

@t3chguy
Copy link
Member Author

t3chguy commented May 18, 2020

Right sure it'd be better as a warning

turt2live
turt2live approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-wise looks fine

src/SlashCommands.tsx Outdated Show resolved Hide resolved
@turt2live turt2live requested a review from a team May 19, 2020 21:10
nadonomy
nadonomy approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

t3chguy
t3chguy commented Jun 19, 2020
View reviewed changes
src/SlashCommands.tsx Outdated Show resolved Hide resolved
@bluecmd
Copy link

bluecmd commented Jul 14, 2020

Hi folks! Great work on Matrix/Riot! Any news on when this fix can be merged? It's pretty annoying to have to run a separate Python script to be able to change people's power levels, so I would greatly appreciate this fix :-).

@t3chguy
Merge branches 'develop' and 't3chguy/fix-op' of github.com:matrix-or…
67d1956 
…g/matrix-react-sdk into t3chguy/fix-op
@t3chguy
Fix /op command to accept only joined/invited users
0305862 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from a team July 14, 2020 10:01
@t3chguy
Copy link
Member Author

t3chguy commented Jul 14, 2020

Hi folks! Great work on Matrix/Riot! Any news on when this fix can be merged? It's pretty annoying to have to run a separate Python script to be able to change people's power levels, so I would greatly appreciate this fix :-).

You do realise there is a graphical way to set power levels in User Info too right?

image
image

@bluecmd
Copy link

bluecmd commented Jul 14, 2020

You do realise there is a graphical way to set power levels in User Info too right?

I had no idea! TIL! Thanks, that's a very nice way.

@t3chguy t3chguy merged commit 91b4193 into develop Jul 16, 2020
@t3chguy t3chguy deleted the t3chguy/fix-op branch July 16, 2020 11:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jryans jryans jryans approved these changes

@turt2live turt2live turt2live approved these changes

@nadonomy nadonomy nadonomy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/op <user-id> is broken Can set power levels of users not in the room
6 participants
@t3chguy @aaronraimist @bluecmd @jryans @turt2live @nadonomy