New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change internal font size from from 15 to 10 #4706
Change internal font size from from 15 to 10 #4706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks sane otherwise
assuming you get it passing tests |
Looks like either your base branch is out of date or you have a branch of the same name in riot-web which is clashing |
Yeah, that's something travis has warned me about. I still had a bunch of open branches on my current fork but I'll be moving to matrix-orgs on monday |
Closing this in favour of #4725 |
We feared that using non integer rem values would cause strange rounding artefacts. We had done some testing which showed that largely this wasn't a worry. However, I've run into the a strange bug on chrome, mac OS (not safari or firefox) which uses a different rounding for vertical and horizontal values. It effects the third decimal significantly. It's usually unoticable but on small circles it's glaring. There was a work around for the toggle switches but now the new radio buttons were looking very disproportionate.
This pr changes our internal base font to 10, making the value of all our $font-Xpx variables a single decimal place long which don't suffer from the rounding problem.
The artefact doesn't show up when you change the base with the slider using the new single decimal place rem values. So, Chrome must be rounding early.
Before:
After: