This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
VoIP virtual rooms, mk II #5639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does a thirdparty protocol lookup to the homeserver to get the corresponding native/virtual user for a matrix ID. Stores the mappings in room account data. Involves some slightly nasty workarounds for that fact that room account data has no local echo.
dbkr
added a commit
to element-hq/element-web
that referenced
this pull request
Feb 12, 2021
or: remove the virtual room mapping config option as per matrix-org/matrix-react-sdk#5639
jryans
suggested changes
Feb 15, 2021
jryans
suggested changes
Feb 16, 2021
jryans
approved these changes
Feb 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does a thirdparty protocol lookup to the homeserver to get the
corresponding native/virtual user for a matrix ID. Stores the
mappings in room account data. Involves some slightly nasty workarounds
for that fact that room account data has no local echo.
Removes tests, which is a bit sad, but the logic we were testing is now in the appservice.
Also tidies up a few things on the PSTN lookup (we were not correctly using the prefixed/nonprefixed
protocol name for the lookup).