This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Build the js-sdk in the CI script #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now it's transpiled
kegsay
reviewed
Jan 11, 2017
| @@ -12,6 +12,9 @@ set -x | |||
| # install the other dependencies | |||
| npm install | |||
|
|
|||
| # we may be using a dev branch of js-sdk in which case we need to build it | |||
| (cd node_modules/matrix-js-sdk && npm run build) | |||
There was a problem hiding this comment.
It's npm run compile as build is used for distribution.
There was a problem hiding this comment.
Now changed as per matrix-org/matrix-js-sdk#320 (comment)
|
LGTM |
otherwise we don't have uglifyjs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now it's transpiled