Ignore unreads in low priority rooms in the space panel

[SimonBrandner]

Fixes element-hq/element-web#16836

---

This PR makes it so that the rooms that were set as Low priority and Mentions & Keywords won't cause a space to have a white dot indicating an unread message if they have unread messages. This is done to avoid the user being overwhlmed by unread messages in the space panel if they consider the room in which the message originated a Low priority

---

Here's what your changelog entry will look like:

✨ Features

• Ignore unreads in low priority rooms in the space panel (#6518). Fixes Space panel shouldn't consider Low Priority for notifications dot element-hq/element-web#16836.

[t3chguy]

code-wise looks sane, though am not a fan of the O(n^2) for each state find the respective room. We can probably be smarter there.

[SimonBrandner]

code-wise looks sane, though am not a fan of the O(n^2) for each state find the respective room. We can probably be smarter there.

If this gets accepted by product, I think we could cache a list of low prio rooms and listen for tag updates to improve this

[daniellekirkwood]

It's not clear from the issue what the chosen solution was from a user perspective, any chance we can get a TLDR and some screenshots?

[SimonBrandner]

It's not clear from the issue what the chosen solution was from a user perspective, any chance we can get a TLDR and some screenshots?

I've updated the description

[daniellekirkwood]

Thanks, @SimonBrandner

It makes sense to me that users are not notified at a Space level with a dot by any messages in rooms that have been deemed by users of little value.

Said differently... A Space will not have a dot for any messages that are in rooms with Low Priority, that are on Mute, or that are in Mentions & Keywords (where the message does not contain a mention or a keyword).

While I think this approach makes sense, I'd like someone from the design org, and specifically with Spaces knowledge to share their thoughts here as there may be some subtle things I'm missing. Maybe @nadonomy or @niquewoodhouse ?

[t3chguy]

@daniellekirkwood one issue here, is marking a room "Low Priority" doesn't impact your notifications whatsoever at the Matrix level, so you can still get push notifications for those rooms. Might be confusing if you get a push or desktop notification but your space panel doesn't light up at all.

[SimonBrandner]

@daniellekirkwood one issue here, is marking a room "Low Priority" doesn't impact your notifications whatsoever at the Matrix level, so you can still get push notifications for those rooms. Might be confusing if you get a push or desktop notification but your space panel doesn't light up at all.

If you get a push notificaiton, the space would light up. This is just about unread messages that did not cause a notification

[t3chguy]

A Space will not have a dot for any messages that are in rooms with Low Priority, that are on Mute, or that are in Mentions & Keywords (where the message does not contain a mention or a keyword).

@SimonBrandner this says otherwise, its or

[daniellekirkwood]

I agree with @t3chguy - it would be odd to get a notification and not know what space it's in - if Low Priority rooms send notifications those would need to show at the space level.

[t3chguy]

Correction, a notification will cause a number rather than a dot, you're right

[daniellekirkwood]

Waiting for approval from Design. Will add labels and update the assignee.