Enable background color on hover for chat panel and thread panel #8644
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,63 +43,75 @@ limitations under the License. | |
| } | ||
|
|
||
| .mx_NewRoomIntro { | ||
| margin-inline-start: var(--BaseCard_EventTile-spacing-inline); | ||
| margin-inline-end: var(--BaseCard_EventTile-spacing-inline); | ||
| } | ||
|
|
||
| .mx_EventTile_content { | ||
| margin-right: 0; | ||
| } | ||
|
|
||
| .mx_EventTile { | ||
| &[data-layout=bubble] { | ||
| &::before { | ||
| z-index: auto; // enable background color on hover | ||
| } | ||
|
|
||
|
There was a problem hiding this comment. Around these changes please see the commit (1dae504) dedicated for |
||
| .mx_ReactionsRow { | ||
| position: relative; // display on hover | ||
| } | ||
| } | ||
|
|
||
| &:not([data-layout="bubble"]) { | ||
| &.mx_EventTile_info .mx_EventTile_line, | ||
| .mx_EventTile_line { | ||
| padding: var(--BaseCard_EventTile_line-padding-block) var(--BaseCard_EventTile-spacing-inline); | ||
| padding-inline-end: $MessageTimestamp_width; // ensure timestamp is not hidden | ||
|
|
||
| .mx_EventTile_e2eIcon { | ||
| inset-inline-start: 8px; | ||
| } | ||
| } | ||
|
|
||
| .mx_DisambiguatedProfile, | ||
| .mx_ReactionsRow, | ||
| .mx_ThreadSummary { | ||
| margin-inline-start: var(--BaseCard_EventTile-spacing-inline); | ||
| } | ||
|
|
||
| .mx_ReactionsRow { | ||
| padding: 0; | ||
|
|
||
| // See margin setting of ReactionsRow on _EventTile.scss | ||
| margin-right: 8px; | ||
| } | ||
|
|
||
| .mx_ThreadSummary { | ||
| margin-right: 0; | ||
| max-width: min(calc(100% - 36px), 600px); | ||
| } | ||
|
|
||
| .mx_EventTile_avatar { | ||
| position: absolute; // for IRC layout | ||
| top: 12px; | ||
| left: -3px; | ||
| } | ||
|
|
||
| .mx_MessageTimestamp { | ||
| position: absolute; // for modern layout and IRC layout | ||
| inset-inline-start: auto; | ||
| inset-inline-end: 0; | ||
| } | ||
|
|
||
| .mx_EventTile_msgOption { | ||
| // Override mx_EventTile_msgOption of mx_EventTile:not([data-layout="bubble"]) | ||
| margin-inline-end: 0; | ||
| } | ||
|
|
||
| &.mx_EventTile_info { | ||
| .mx_EventTile_avatar { | ||
| left: 18px; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -134,8 +146,8 @@ limitations under the License. | |
| .mx_GenericEventListSummary:not([data-layout=bubble]) { | ||
| .mx_EventTile_line, | ||
| > .mx_GenericEventListSummary_unstyledList > .mx_EventTile_info .mx_EventTile_avatar ~ .mx_EventTile_line { | ||
| padding-inline-start: var(--BaseCard_EventTile-spacing-inline); | ||
| padding-inline-end: var(--BaseCard_EventTile-spacing-inline); | ||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
inlineis better as it follows the rule of logical properties. You could double-check by looking up--BaseCard_EventTile-spacing-horizontal.