Add Element Call room settings #9347

SimonBrandner · 2022-10-04T11:59:36Z

Here's what your changelog entry will look like:

✨ Features

Add Element Call room settings (#9347).

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

src/components/views/settings/tabs/room/RolesRoomSettingsTab.tsx

src/components/views/settings/tabs/room/VoipRoomSettingsTab.tsx

test/createRoom-test.ts

src/components/views/settings/tabs/room/VoipRoomSettingsTab.tsx

test/components/views/settings/tabs/room/VoipRoomSettingsTab-test.tsx

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

src/components/views/settings/tabs/room/RolesRoomSettingsTab.tsx

src/createRoom.ts

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

turt2live

this is looking better, though the brand consideration and object type still need addressing.

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

robintown

Looks good to go

Resolved, and reviewer is away

turt2live

it won't let me request changes now :(

turt2live · 2022-10-07T18:16:47Z

src/components/views/rooms/RoomHeader.tsx

@@ -195,10 +195,11 @@ const VideoCallButton: FC<VideoCallButtonProps> = ({ room, busy, setBusy, behavi
    let menu: JSX.Element | null = null;
    if (menuOpen) {
        const buttonRect = buttonRef.current!.getBoundingClientRect();
+        const brand = SdkConfig.get("element_call").brand;


This is an error waiting to happen: we should be using SdkConfig.get().element_call?.brand ?? DEFAULTS.element_call.brand instead.

Addressed by #9376

@toger5

* Include a file-safe room name and ISO date in chat exports ([\matrix-org#9440](matrix-org#9440)). Fixes element-hq/element-web#21812 and element-hq/element-web#19724. * Room call banner ([\matrix-org#9378](matrix-org#9378)). Fixes element-hq/element-web#23453. Contributed by @toger5. * Device manager - spinners while devices are signing out ([\matrix-org#9433](matrix-org#9433)). Fixes element-hq/element-web#15865. * Device manager - silence call ringers when local notifications are silenced ([\matrix-org#9420](matrix-org#9420)). * Pass the current language to Element Call ([\matrix-org#9427](matrix-org#9427)). * Hide screen-sharing button in Element Call on desktop ([\matrix-org#9423](matrix-org#9423)). * Add reply support to WysiwygComposer ([\matrix-org#9422](matrix-org#9422)). Contributed by @florianduros. * Disconnect other connected devices (of the same user) when joining an Element call ([\matrix-org#9379](matrix-org#9379)). * Device manager - device tile main click target ([\matrix-org#9409](matrix-org#9409)). * Add formatting buttons to the rich text editor ([\matrix-org#9410](matrix-org#9410)). Contributed by @florianduros. * Device manager - current session context menu ([\matrix-org#9386](matrix-org#9386)). * Remove piwik config fallback for privacy policy URL ([\matrix-org#9390](matrix-org#9390)). * Add the first step to integrate the matrix wysiwyg composer ([\matrix-org#9374](matrix-org#9374)). Contributed by @florianduros. * Device manager - UA parsing tweaks ([\matrix-org#9382](matrix-org#9382)). * Device manager - remove client information events when disabling setting ([\matrix-org#9384](matrix-org#9384)). * Add Element Call participant limit ([\matrix-org#9358](matrix-org#9358)). * Add Element Call room settings ([\matrix-org#9347](matrix-org#9347)). * Device manager - render extended device information ([\matrix-org#9360](matrix-org#9360)). * New group call experience: Room header and PiP designs ([\matrix-org#9351](matrix-org#9351)). * Pass language to Jitsi Widget ([\matrix-org#9346](matrix-org#9346)). Contributed by @Fox32. * Add notifications and toasts for Element Call calls ([\matrix-org#9337](matrix-org#9337)). * Device manager - device type icon ([\matrix-org#9355](matrix-org#9355)). * Delete the remainder of groups ([\matrix-org#9357](matrix-org#9357)). Fixes element-hq/element-web#22770. * Device manager - display client information in device details ([\matrix-org#9315](matrix-org#9315)). * Send Content-Type: application/json header for integration manager /register API ([\matrix-org#9490](matrix-org#9490)). Fixes element-hq/element-web#23580. * Device manager - put client/browser device metadata in correct section ([\matrix-org#9447](matrix-org#9447)). * update the room unread notification counter when the server changes the value without any related read receipt ([\matrix-org#9438](matrix-org#9438)). * Don't show call banners in video rooms ([\matrix-org#9441](matrix-org#9441)). * Prevent useContextMenu isOpen from being true if the button ref goes away ([\matrix-org#9418](matrix-org#9418)). Fixes matrix-org/element-web-rageshakes#15637. * Automatically focus the WYSIWYG composer when you enter a room ([\matrix-org#9412](matrix-org#9412)). * Improve the tooltips on the call lobby join button ([\matrix-org#9428](matrix-org#9428)). * Pass the homeserver's base URL to Element Call ([\matrix-org#9429](matrix-org#9429)). Fixes element-hq/element-web#23301. * Better accommodate long room names in call toasts ([\matrix-org#9426](matrix-org#9426)). * Hide virtual widgets from the room info panel ([\matrix-org#9424](matrix-org#9424)). Fixes element-hq/element-web#23494. * Inhibit clicking on sender avatar in threads list ([\matrix-org#9417](matrix-org#9417)). Fixes element-hq/element-web#23482. * Correct the dir parameter of MSC3715 ([\matrix-org#9391](matrix-org#9391)). Contributed by @dhenneke. * Use a more correct subset of users in `/remakeolm` developer command ([\matrix-org#9402](matrix-org#9402)). * use correct default for notification silencing ([\matrix-org#9388](matrix-org#9388)). Fixes element-hq/element-web#23456. * Device manager - eagerly create `m.local_notification_settings` events ([\matrix-org#9353](matrix-org#9353)). * Close incoming Element call toast when viewing the call lobby ([\matrix-org#9375](matrix-org#9375)). * Always allow enabling sending read receipts ([\matrix-org#9367](matrix-org#9367)). Fixes element-hq/element-web#23433. * Fixes (element-hq/element-web/issues/22609) where the white theme is not applied when `white -> dark -> white` sequence is done. ([\matrix-org#9320](matrix-org#9320)). Contributed by @florianduros. * Fix applying programmatically set height for "top" room layout ([\matrix-org#9339](matrix-org#9339)). Contributed by @Fox32.

SimonBrandner added 5 commits October 4, 2022 13:56

Correctly setup EC perms on room creation

b421911

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Add VoipRoomSettingsTab

055faf6

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Show VoipRoomSettingsTab

0cdf7ca

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Show MSC3401 perms in room settings

ebcd2d5

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

i18n

88c3666

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

SimonBrandner added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Oct 4, 2022

SimonBrandner mentioned this pull request Oct 4, 2022

Implement the new group call designs (Element Call) 1/2 element-hq/element-web#23107

Closed

9 tasks

github-actions bot deployed to Netlify October 4, 2022 12:04 View deployment

Remove ScreenName

761e528

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

github-actions bot deployed to Netlify October 4, 2022 12:12 View deployment

SimonBrandner added 4 commits October 4, 2022 14:41

Hide behind labs flag

adf9f19

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Add testid

b92a576

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Add tests

5491451

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

i18n

eb8b242

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

github-actions bot deployed to Netlify October 4, 2022 14:18 View deployment

SimonBrandner marked this pull request as ready for review October 4, 2022 14:21

SimonBrandner requested a review from a team as a code owner October 4, 2022 14:21

SimonBrandner requested review from germain-gg, turt2live and t3chguy October 4, 2022 14:21

turt2live requested changes Oct 5, 2022

View reviewed changes

SimonBrandner added 4 commits October 5, 2022 17:05

Don't mix " and '

1b19491

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Fix indent

1e56fbc

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Fix test name

278f0fd

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Try to use existing power levels

9983434

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

SimonBrandner requested review from turt2live and removed request for germain-gg and t3chguy October 5, 2022 15:56

robintown reviewed Oct 5, 2022

View reviewed changes

src/components/views/settings/tabs/room/RolesRoomSettingsTab.tsx Outdated Show resolved Hide resolved

src/components/views/settings/tabs/room/RolesRoomSettingsTab.tsx Outdated Show resolved Hide resolved

src/createRoom.ts Show resolved Hide resolved

turt2live removed their request for review October 5, 2022 20:47

Disable when insufficient perms

2a6bbda

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

SimonBrandner requested a review from robintown October 6, 2022 15:55

github-actions bot deployed to Netlify October 6, 2022 16:00 View deployment

Fix tests

756bdaf

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

github-actions bot deployed to Netlify October 6, 2022 16:47 View deployment

turt2live previously requested changes Oct 6, 2022

View reviewed changes

SimonBrandner mentioned this pull request Oct 7, 2022

Fix power_level_content_override type matrix-org/matrix-js-sdk#2740

Closed

Don't cast as any

14d9bab

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

github-actions bot deployed to Netlify October 7, 2022 13:31 View deployment

SimonBrandner mentioned this pull request Oct 7, 2022

Fix power_level_content_override type matrix-org/matrix-js-sdk#2741

Merged

Merge branch 'develop' into SimonBrandner/feat/ec-perms

b62e74b

github-actions bot deployed to Netlify October 7, 2022 13:36 View deployment

SimonBrandner mentioned this pull request Oct 7, 2022

Add Element Call brand element-hq/element-web#23443

Merged

SimonBrandner requested a review from turt2live October 7, 2022 14:10

SimonBrandner added 3 commits October 7, 2022 16:10

Add EC brand

2bcdbf7

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

i18n

e7000b6

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Delint

d5ee3d6

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

github-actions bot deployed to Netlify October 7, 2022 14:25 View deployment

Fix tests

dfd4031

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

github-actions bot deployed to Netlify October 7, 2022 14:51 View deployment

robintown approved these changes Oct 7, 2022

View reviewed changes

Merge branch 'develop' into SimonBrandner/feat/ec-perms

e19e015

SimonBrandner enabled auto-merge (squash) October 7, 2022 17:32

github-actions bot deployed to Netlify October 7, 2022 17:36 View deployment

SimonBrandner merged commit 26a74a1 into develop Oct 7, 2022

SimonBrandner deleted the SimonBrandner/feat/ec-perms branch October 7, 2022 18:10

turt2live reviewed Oct 7, 2022

View reviewed changes

SimonBrandner mentioned this pull request Oct 7, 2022

Handle missing Element Call brand #9376

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Element Call room settings #9347

Add Element Call room settings #9347

SimonBrandner commented Oct 4, 2022 •

edited by github-actions bot

turt2live left a comment

robintown left a comment

turt2live left a comment

turt2live Oct 7, 2022

SimonBrandner Oct 7, 2022

Add Element Call room settings #9347

Add Element Call room settings #9347

Conversation

SimonBrandner commented Oct 4, 2022 • edited by github-actions bot

✨ Features

turt2live left a comment

Choose a reason for hiding this comment

robintown left a comment

Choose a reason for hiding this comment

turt2live left a comment

Choose a reason for hiding this comment

turt2live Oct 7, 2022

Choose a reason for hiding this comment

SimonBrandner Oct 7, 2022

Choose a reason for hiding this comment

SimonBrandner commented Oct 4, 2022 •

edited by github-actions bot