Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧵 Enable threads by default #9736

Merged
merged 11 commits into from Dec 13, 2022
Merged

🧵 Enable threads by default #9736

merged 11 commits into from Dec 13, 2022

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Dec 12, 2022 •
edited by github-actions bot

The moment you've all been waiting for... Threads are enabled by default!

The labs flag had to change its key so that it will be enabled for all users by default and so that it overrides the previously set preferences.
We will keep it as a labs flag until the next release cycle. After that point it won't be possible to disable threads anymore and all references to it as a "beta feature" will be removed frm the product

Related to element-hq/element-meta#566

Fixes element-hq/element-web#19270
Fixes element-hq/element-web#21910
Fixes element-hq/element-web#23946

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

@germain-gg germain-gg added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Dec 12, 2022
@germain-gg
Copy link
Contributor Author

All the files that are not passing the quality gates check are only in there because the thread feature name has been changed from feature_thread to feature_threadstable.

@matrix-org/element-web-app-team could we bypass that check and merge that feature in. I'll DM you in time tomorrow to get this in. Thank you 🙏

@germain-gg germain-gg marked this pull request as ready for review December 12, 2022 15:45
@germain-gg germain-gg requested a review from a team as a code owner December 12, 2022 15:45
@t3chguy t3chguy requested a review from a team December 12, 2022 17:25
@turt2live
Copy link
Member

https://github.com/orgs/matrix-org/teams/element-web-app-team could we bypass that check and merge that feature in. I'll DM you in time tomorrow to get this in. Thank you 🙏

By DM I think you mean message in the Web App Team room ;)

(there's >1 person who can actively take ownership of these things now - it's important to use the team room)

@germain-gg
Copy link
Contributor Author

@t3chguy I suggest removing the product review.
This has already been discussed with @daniellekirkwood and she won't be able to give a review today.

@turt2live This is what I meant, hence why i tagged the app team above.

@t3chguy
Copy link
Member

t3chguy commented Dec 13, 2022

The issue it fixes is marked as needs product, and all changes like this need product sign off. There should be other product people aware of the project around, alternatively it shouldn't have been left to the last moment.

@amywalkerdev
Copy link

This approved from a product point of view, its been planned for a few weeks and both myself and @daniellekirkwood are aware of it

@t3chguy
Copy link
Member

t3chguy commented Dec 13, 2022 •
edited

@amywalkerdev any chance you could leave an actual ✔️ approving review - those have better visibility on github

amywalkerdev
amywalkerdev approved these changes Dec 13, 2022
View reviewed changes
Copy link

@amywalkerdev amywalkerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved :)

t3chguy
t3chguy requested changes Dec 13, 2022
View reviewed changes
src/MatrixClientPeg.ts Outdated Show resolved Hide resolved
src/components/structures/RoomSearchView.tsx Outdated Show resolved Hide resolved
src/components/views/context_menus/MessageContextMenu.tsx Outdated Show resolved Hide resolved
src/components/views/rooms/EventTile.tsx Outdated Show resolved Hide resolved
src/settings/Settings.tsx Show resolved Hide resolved
test/components/structures/TimelinePanel-test.tsx Outdated Show resolved Hide resolved
test/components/views/settings/tabs/user/__snapshots__/LabsUserSettingsTab-test.tsx.snap Outdated Show resolved Hide resolved
@germain-gg germain-gg mentioned this pull request Dec 13, 2022
Merged
3 tasks
@t3chguy t3chguy added the X-Release-Blocker This affects the current release cycle and must be solved for a release to happen label Dec 13, 2022
@t3chguy t3chguy merged commit 2d2755d into develop Dec 13, 2022
@t3chguy t3chguy deleted the gsouquet/delabs-threads branch December 13, 2022 15:09
@germain-gg germain-gg mentioned this pull request Dec 21, 2022
Merged
3 tasks
su-ex added a commit to SchildiChat/element-desktop that referenced this pull request Jan 15, 2023
@su-ex
Merge tag 'v1.11.17' into sc
6d83055 
* This allows the update server to be entirely static, such as a CDN or object store, as defined at https ([\element-hq#461](element-hq#461)).
* Enable threads by default ([\#9736](matrix-org/matrix-react-sdk#9736)). Fixes element-hq/element-web#19270 element-hq/element-web#21910 and element-hq/element-web#23946.
* Add inline code formatting to rich text editor ([\#9720](matrix-org/matrix-react-sdk#9720)).
* Add emoji handling for plain text mode of the new rich text editor ([\#9727](matrix-org/matrix-react-sdk#9727)).
* Overlay virtual room call events into main timeline ([\#9626](matrix-org/matrix-react-sdk#9626)). Fixes element-hq/element-web#22929.
* Adds a new section under "Room Settings" > "Roles & Permissions" which adds the possibility to multiselect users from this room and grant them more permissions. ([\#9596](matrix-org/matrix-react-sdk#9596)). Contributed by @GoodGuyMarco.
* Add emoji handling for rich text mode ([\#9661](matrix-org/matrix-react-sdk#9661)).
* Add setting to hide bold notifications ([\#9705](matrix-org/matrix-react-sdk#9705)).
* Further password reset flow enhancements ([\#9662](matrix-org/matrix-react-sdk#9662)).
* Snooze the bulk unverified sessions reminder on dismiss ([\#9706](matrix-org/matrix-react-sdk#9706)).
* Honor advanced audio processing settings when recording voice messages ([\#9610](matrix-org/matrix-react-sdk#9610)). Contributed by @MrAnno.
* Improve the visual balance of bubble layout ([\#9704](matrix-org/matrix-react-sdk#9704)).
* Add config setting to disable bulk unverified sessions nag ([\#9657](matrix-org/matrix-react-sdk#9657)).
* Only display bulk unverified sessions nag when current sessions is verified ([\#9656](matrix-org/matrix-react-sdk#9656)).
* Separate labs and betas more clearly ([\#8969](matrix-org/matrix-react-sdk#8969)). Fixes element-hq/element-web#22706.
* Show user an error if we fail to create a DM for verification. ([\#9624](matrix-org/matrix-react-sdk#9624)).
* Prevent unnecessary m.direct updates ([\#9805](matrix-org/matrix-react-sdk#9805)). Fixes element-hq/element-web#24059.
* Fix checkForPreJoinUISI for thread roots ([\#9803](matrix-org/matrix-react-sdk#9803)). Fixes element-hq/element-web#24054.
* Load RTE components only when RTE labs is enabled ([\#9804](matrix-org/matrix-react-sdk#9804)).
* Fix issue where thread panel did not update correctly ([\#9746](matrix-org/matrix-react-sdk#9746)). Fixes element-hq/element-web#23971.
* Remove async call to get virtual room from room load ([\#9743](matrix-org/matrix-react-sdk#9743)). Fixes element-hq/element-web#23968.
* Check each thread for unread messages. ([\#9723](matrix-org/matrix-react-sdk#9723)).
* Device manage - handle sessions that don't support encryption ([\#9717](matrix-org/matrix-react-sdk#9717)). Fixes element-hq/element-web#23722.
* Fix hover state for formatting buttons (Rich text editor) (fix element-hq/element-web/issues/23832) ([\#9715](matrix-org/matrix-react-sdk#9715)).
* Don't allow group calls to be unterminated ([\#9710](matrix-org/matrix-react-sdk#9710)).
* Fix replies to emotes not showing as inline ([\#9707](matrix-org/matrix-react-sdk#9707)). Fixes element-hq/element-web#23903.
* Update copy of 'Change layout' button to match Element Call ([\#9703](matrix-org/matrix-react-sdk#9703)).
* Fix call splitbrains when switching between rooms ([\#9692](matrix-org/matrix-react-sdk#9692)).
* bugfix: fix an issue where the Notifier would incorrectly fire for non-timeline events ([\#9664](matrix-org/matrix-react-sdk#9664)). Fixes element-hq/element-web#17263.
* Fix power selector being wrongly disabled for admins themselves ([\#9681](matrix-org/matrix-react-sdk#9681)). Fixes element-hq/element-web#23882.
* Show day counts in call durations ([\#9641](matrix-org/matrix-react-sdk#9641)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@amywalkerdev amywalkerdev amywalkerdev approved these changes

@richvdh richvdh Awaiting requested review from richvdh richvdh is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Release-Blocker This affects the current release cycle and must be solved for a release to happen
Projects
None yet
Milestone
No milestone
4 participants
@germain-gg @turt2live @t3chguy @amywalkerdev