Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring/Unignoring a user does not trigger a timeline refresh/reset #2284

Closed
Velin92 opened this issue Jul 14, 2023 · 3 comments · Fixed by #2504
Closed

Ignoring/Unignoring a user does not trigger a timeline refresh/reset #2284

Velin92 opened this issue Jul 14, 2023 · 3 comments · Fixed by #2504
Assignees
Labels
bug Something isn't working X-Needs-Rust

Comments

@Velin92
Copy link
Contributor

Velin92 commented Jul 14, 2023

Before ignoring or unignoring a user triggered a reset in the timeline to filter out (or reinsert) messages from that blocked user.
It will prevent new messages from being inserted in the timeline from the ignore user (or viceversa make new messages appear if is unignored) but will not handle previous existing ones.

An app reboot on Element X is required to restore the state of the user.

element-hq/element-x-ios#911

@kittykat
Copy link

kittykat commented Jul 17, 2023

Also related: element-hq/element-x-ios#910

@kittykat kittykat added the bug Something isn't working label Jul 17, 2023
@Hywan Hywan self-assigned this Aug 23, 2023
@Hywan
Copy link
Member

Hywan commented Aug 23, 2023

I've another bug:

  • Ignoring a member
  • Closing the app
  • Opening the app
  • The message of the ignored member still appears, but at the top of the timeline.

Edit: it comes from the SlidingSyncResponse timeline queue/cache.

@Hywan
Copy link
Member

Hywan commented Aug 24, 2023

It has stopped working because the code you wrote in #1705 has been removed when SlidingSync bindings have been removed in #2222. That's the problem when bindings do more stuff than just bindings ;-).

Working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working X-Needs-Rust
Projects
None yet
4 participants