chore(ffi): Bye bye Sliding Sync bindings! #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `RoomList` and `EncryptionSync` API provide a better developer experience and address concrete needs. Nobody no longer uses the Sliding Sync bindings, so we can remove them.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2222 +/- ##
=======================================
Coverage 76.85% 76.85%
=======================================
Files 168 168
Lines 17759 17759
=======================================
Hits 13649 13649
Misses 4110 4110 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1911.
The
RoomListandEncryptionSyncAPI provide a better developer experience and address concrete needs. Nobody no longer uses the Sliding Sync bindings, so we can remove them.