feat: resetting the timeline when an ignore user list event is received #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanceriu
reviewed
Mar 26, 2023
jplatte
reviewed
Mar 27, 2023
jplatte
reviewed
Mar 27, 2023
Co-authored-by: Jonas Platte <jplatte@matrix.org>
jplatte
approved these changes
Mar 27, 2023
Co-authored-by: Jonas Platte <jplatte@matrix.org>
jplatte
approved these changes
Mar 27, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1705 +/- ##
==========================================
- Coverage 76.13% 76.12% -0.02%
==========================================
Files 137 137
Lines 15234 15241 +7
==========================================
+ Hits 11599 11602 +3
- Misses 3635 3639 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
# Conflicts: # bindings/matrix-sdk-ffi/src/sliding_sync.rs # crates/matrix-sdk-base/src/client.rs # crates/matrix-sdk/src/client/mod.rs
|
I see that some changes have been made on how we handle the reception of the tasks, so I aligned my branch to these changes, let me know if they work for you @jplatte |
jplatte
reviewed
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will require also a restart of SS and the cache to be cleaned, which @Hywan is working on separately, otherwise in offline cases the cold cache could restore the old messages.