Make sync_token accessor private #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- matrix_sdk_base::sync::SyncResponse is the internal representation that we can update to account for sliding sync - matrix_sdk::sync::SyncResponse is `/v3/`-specific and should not change
Codecov ReportBase: 74.53% // Head: 74.57% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1216 +/- ##
==========================================
+ Coverage 74.53% 74.57% +0.04%
==========================================
Files 112 112
Lines 12805 12814 +9
==========================================
+ Hits 9544 9556 +12
+ Misses 3261 3258 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
poljar
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not removed here because that would mean people have to manage it externally for clients that keep non-crypto state across app runs. However, to make use cases with multiple concurrent syncs possible, we could do so in a follow-up and require people to manage the sync token themselves. Many of the examples seem to suggest that it has to be passed manually anyways..
Supersedes #1211.