Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase default request timeout to 30s #1320

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Increase default request timeout to 30s #1320

merged 1 commit into from
Jan 4, 2023

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Jan 4, 2023

Apparently this is what Element clients do, so probably a better default than the much lower value we have now.

@jplatte jplatte requested a review from poljar January 4, 2023 16:56
manuroe
manuroe approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@manuroe manuroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jplatte jplatte merged commit 6780dc0 into main Jan 4, 2023
@jplatte jplatte deleted the jplatte/request-timeout branch January 4, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poljar poljar poljar approved these changes

@manuroe manuroe manuroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jplatte @poljar @manuroe