Add an error type to the CryptoStore trait #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 72.78% // Head: 72.67% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1477 +/- ##
==========================================
- Coverage 72.78% 72.67% -0.12%
==========================================
Files 124 125 +1
Lines 13321 13384 +63
==========================================
+ Hits 9696 9727 +31
- Misses 3625 3657 +32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This makes it easier to implement it. However, using a different error type than CryptoStoreError is a non-trivial change, so left for the coming commits for all stores except the memory store.
jplatte
force-pushed
the
jplatte/store-refactor
branch
from
a816904
to
18626b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes store implementations cleaner at the expense of some boilerplate code in matrix-sdk-crypto.