Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run event / notification handler callbacks in order #345

Merged
merged 1 commit into from
Sep 18, 2021
Merged

Run event / notification handler callbacks in order #345

merged 1 commit into from
Sep 18, 2021

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Sep 17, 2021

Fixes #344.

@poljar
Copy link
Contributor

poljar commented Sep 17, 2021

Could you please rebase this onto master, I borked the CI and a fix just landed in master.

@poljar poljar merged commit 533c86d into matrix-org:master Sep 18, 2021
@poljar
Copy link
Contributor

poljar commented Sep 18, 2021

Thanks, merged.

@jplatte jplatte deleted the in-order-event-handling branch September 18, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poljar poljar poljar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The new event handler doesn't guarantee that the callbacks are executed in the order the events are received.
2 participants
@jplatte @poljar