sdk: implement a sending queue #3465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjbvr
force-pushed
the
bnjbvr/shared-sending-queue
branch
3 times, most recently
from
e1e0372
to
7ceace5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3465 +/- ##
==========================================
+ Coverage 83.63% 83.72% +0.08%
==========================================
Files 254 255 +1
Lines 25592 25752 +160
==========================================
+ Hits 21405 21560 +155
- Misses 4187 4192 +5 ☔ View full report in Codecov by Sentry. |
bnjbvr
force-pushed
the
bnjbvr/shared-sending-queue
branch
from
bc4da6d
to
edf6867
Compare
bnjbvr
changed the title
|
Extracted some bits of this PR as #3475, as an attempt to make reviewing it easier. |
bnjbvr
force-pushed
the
bnjbvr/shared-sending-queue
branch
from
edf6867
to
dc0f2e8
Compare
…ground This implements the following features: - enabling/disabling the sending queue at a client-wide granularity, - one sending queue per room, that lives until the client is shutting down, - retrying sending an event three times, if it failed in the past, with some exponential backoff to attempt to re-send, - allowing to cancel sending an event we haven't sent yet. fixup sdk
A client would require this to know that the sending queue has been globally disabled, across all the rooms, otherwise they couldn't know that it needs to be re-enabled later on.
So as to not use sync mutexes across await points, we have to use an async mutex, BUT it can't be immediately called in a wiremock responder, so we need to shoe-horn a bit: create a new tokio runtime, which can only be called from another running thread, etc. It's a bit ugly, but I couldn't find another mechanism to block the responder from returning a Response immediately; happy to change that anytime if there's a simpler way.
bnjbvr
force-pushed
the
bnjbvr/shared-sending-queue
branch
from
dc0f2e8
to
ae66ef2
Compare
Thanks @Hywan for the review comments!
Hywan
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of #3361, except for storing/reloading the local echoes from the disk.