Use Nightly Clippy + bug fixes #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poljar
requested changes
Sep 21, 2021
| @@ -87,7 +87,9 @@ pub struct BaseClient { | |||
| olm: Arc<Mutex<Option<OlmMachine>>>, | |||
| #[cfg(feature = "encryption")] | |||
| cryptostore: Arc<Mutex<Option<Box<dyn CryptoStore>>>>, | |||
| #[cfg(feature = "encryption")] | |||
There was a problem hiding this comment.
Is this right? The store_path is used for the sled state store as well, which can be enabled without having encryption enabled.
There was a problem hiding this comment.
I thought I checked all usages. I'll have another look.
There was a problem hiding this comment.
I checked: With the sled_state_store feature, only config.store_path is used (which I did not touch), not client.store_path.
There was a problem hiding this comment.
Oh sorry, I seem to have confused those two.
| @@ -7,6 +7,7 @@ use matrix_sdk::{ | |||
| use url::Url; | |||
|
|
|||
| #[derive(Debug)] | |||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
Why is this dead if it's clearly used?
There was a problem hiding this comment.
It's written, but never read except for through Debug, which Nightly rustc no longer considers as a "real" use.
poljar
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.