timeline: use the previous content's membership info when it's missing from the current membership event #3648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3648 +/- ##
=======================================
Coverage 84.25% 84.26%
=======================================
Files 259 259
Lines 26609 26621 +12
=======================================
+ Hits 22420 22431 +11
- Misses 4189 4190 +1 ☔ View full report in Codecov by Sentry. |
Hywan
approved these changes
Jul 4, 2024
| @@ -201,6 +201,48 @@ async fn test_room_member() { | |||
| assert_matches!(profile.displayname_change(), Some(_)); | |||
| assert_matches!(profile.avatar_url_change(), None); | |||
|
|
|||
| let mut fourth_room_member_content = RoomMemberEventContent::new(MembershipState::Join); | |||
| fourth_room_member_content.displayname = Some("Alice In Wonderland".to_owned()); | |||
|
This requires adding an exception client-side (at least for EX Android) but I confirm it works as expected. Thanks! |
|
Thanks for testing! will land the first part, and see how we can improve the disambiguation mappings. |
…g from the current membership event
Synapse returns a bare `{ "membership": "leave" }` as the content of a
room membership event (for leave membership changes and likely others).
In this case, it'd still be nice to have some kind of display
name/avatar URL to show in UIs; it's possible to reuse information from
the previous member event, if available.
bnjbvr
force-pushed
the
bnjbvr/timeline-item-displayname-or-avatar-from-prev-content
branch
from
b5e8cf2
to
61be6e8
Compare
bnjbvr
deleted the
bnjbvr/timeline-item-displayname-or-avatar-from-prev-content
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synapse returns a bare
{ "membership": "leave" }as the content of a room membership event (for leave membership changes and likely others). In this case, it'd still be nice to have some kind of display name/avatar URL to show in UIs; it's possible to reuse information from the previous member event, if available.