Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Initial apple platforms support #571

Merged
merged 20 commits into from
May 18, 2022
Merged

feat: Initial apple platforms support #571

merged 20 commits into from
May 18, 2022

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Apr 5, 2022

No description provided.

@jplatte jplatte mentioned this pull request Apr 5, 2022
Merged
@jplatte jplatte force-pushed the jplatte/matrix-sdk-ffi branch 5 times, most recently from b0c53a8 to 2300c1b Compare April 12, 2022 14:37
jplatte and others added 5 commits May 11, 2022 11:07
@jplatte @stefanceriu @gnunicorn
feat: Initial apple platforms support
ab9d8eb 
Co-authored-by: Stefan Ceriu <stefan.ceriu@gmail.com>
Co-authored-by: Benjamin Kampmann <ben.kampmann@gmail.com>
@jplatte
squash! feat: Initial apple platforms support
56cfe8f 
Some FFI API cleanup
@jplatte
squash! feat: Initial apple platforms support
9909cb5 
Enable sending of messages
@jplatte
fixup! feat: Initial apple platforms support
40dcc98
@jplatte
Cleanup after rebase
1fdd1ab
@codecov
Copy link

codecov bot commented May 11, 2022 •
edited
Loading

Codecov Report

Merging #571 (6a1b85c) into main (248fff3) will decrease coverage by 0.84%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   73.48%   72.63%   -0.85%     
==========================================
  Files         101      107       +6     
  Lines       15132    15935     +803     
==========================================
+ Hits        11120    11575     +455     
- Misses       4012     4360     +348
Impacted Files Coverage Δ
crates/matrix-sdk-crypto/src/machine.rs 73.54% <ø> (ø)
crates/matrix-sdk-ffi/src/backward_stream.rs 0.00% <0.00%> (ø)
crates/matrix-sdk-ffi/src/client.rs 0.00% <0.00%> (ø)
crates/matrix-sdk-ffi/src/lib.rs 0.00% <0.00%> (ø)
crates/matrix-sdk-ffi/src/messages.rs 0.00% <0.00%> (ø)
crates/matrix-sdk-ffi/src/room.rs 0.00% <0.00%> (ø)
crates/matrix-sdk/src/sync.rs 52.30% <0.00%> (-15.70%) ⬇️
crates/matrix-sdk-base/src/store/memory_store.rs 90.90% <0.00%> (-2.91%) ⬇️
crates/matrix-sdk/src/client/builder.rs 63.80% <0.00%> (-2.21%) ⬇️
crates/matrix-sdk-sled/src/state_store.rs 83.02% <0.00%> (-0.67%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 248fff3...6a1b85c. Read the comment docs.

@gnunicorn gnunicorn marked this pull request as ready for review May 16, 2022 11:42
gnunicorn and others added 13 commits May 17, 2022 12:51
gnunicorn
gnunicorn approved these changes May 18, 2022
View reviewed changes
bindings/apple/build_xcframework.sh
@@ -0,0 +1,89 @@
#!/usr/bin/env bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move these bash into xtask

@gnunicorn gnunicorn merged commit 736f0e7 into main May 18, 2022
@gnunicorn gnunicorn deleted the jplatte/matrix-sdk-ffi branch May 18, 2022 11:14
@gnunicorn gnunicorn mentioned this pull request May 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poljar poljar poljar left review comments

@gnunicorn gnunicorn gnunicorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jplatte @gnunicorn @poljar @stefanceriu