Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing knock rule on v7 room #3648

Closed
gnieto opened this issue Jan 16, 2022 · 2 comments · Fixed by #3661
Closed

Missing knock rule on v7 room #3648

gnieto opened this issue Jan 16, 2022 · 2 comments · Fixed by #3661
Assignees
@turt2live
Labels
release-blocker spec-bug Something which is in the spec, but is wrong

Comments

@gnieto
Copy link

gnieto commented Jan 16, 2022

Link to problem area:

https://github.com/matrix-org/matrix-doc/blame/16ec511e9c858b9fd49456922132f4fc389e4ddd/content/rooms/v7.md#L134-L138

Issue

Rule iv. Otherwise, reject seems to be missing on knock membership auth rule (Rule 4.6). It was present on a previous version of the spec ( https://github.com/matrix-org/matrix-doc/pull/3432/files#diff-d6b46653922eec4cccb889228b3bc6a1eca1f2aaec466b486e21b734071f017eL40-L48), but it's missing since this PR was merged: #3432

Expected behaviour

The mentioned rule should be restored
@gnieto gnieto added the spec-bug Something which is in the spec, but is wrong label Jan 16, 2022
@gnieto
Copy link
Author

gnieto commented Jan 19, 2022

This rule seems to be missing also on room v8 and v9 which were recently merged on: #3387

@turt2live turt2live self-assigned this Jan 19, 2022
@turt2live
Copy link
Member

I don't think it's technically required because it'll fall into unknown, thus reject, but it's very sensible to put back

turt2live added a commit that referenced this issue Jan 19, 2022
@turt2live
Re-add knock's otherwise, reject per MSC2403
ba9c31a 
Fixes #3648
@turt2live turt2live mentioned this issue Jan 19, 2022
Merged
turt2live added a commit that referenced this issue Jan 20, 2022
@turt2live
Re-add knock's otherwise, reject per MSC2403 (#3661)
4a597ac 
* Re-add knock's `otherwise, reject` per MSC2403

Fixes #3648

* changelog + changelog for 3432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
release-blocker spec-bug Something which is in the spec, but is wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-add knock's otherwise, reject per MSC2403 matrix-org/matrix-spec-proposals
3 participants
@turt2live @richvdh @gnieto