Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2403: Add "knock" feature #2403

Open
wants to merge 7 commits into
base: master
from
Open

Conversation

@Sorunome
Copy link
Contributor

Sorunome commented Jan 9, 2020

Rendered

Soru is also interested in providing implementations in both synapse and riot-web for this, however, as her workload is currently rather high so the development progress would likely be slowly.

Signed-off-by: Sorunome mail@sorunome.de

Synapse PR

Sorunome added 2 commits Jan 9, 2020
@Sorunome Sorunome changed the title MSC2400: Add "knock" MSC2403: Add "knock" Jan 9, 2020
@Sorunome Sorunome changed the title MSC2403: Add "knock" MSC2403: Add "knock" feature Jan 9, 2020
Copy link
Member

anoadragon453 left a comment

Looks promising and has lots of potential applications for bridges! I'm excited to see where this goes :)

Edit: This was meant to be a Request Changes for the below issues, but doesn't make much of a difference at the moment.

### Join Rules
The `join_rule` of `m.room.join_rules` must be set to "invite". This means that people can't knock
in public rooms. Additionaly the new join rule "private" is introduced. This is so that people can,
when creating a new room, prevent anyone from knocking.

This comment has been minimized.

Copy link
@anoadragon453

anoadragon453 Jan 12, 2020

Member

Can't one just set the required power level to send a knock event to something about the default power level?

This comment has been minimized.

Copy link
@Sorunome

Sorunome Jan 13, 2020

Author Contributor

Yes, we could. The join rules could be more easily exposed via UI, however, thus making the PL approach the advanced one while the join rules one is the simple setting, basically.

proposals/2403-knock.md Outdated Show resolved Hide resolved
@turt2live turt2live self-requested a review Jan 13, 2020
Sorunome added 2 commits Jan 13, 2020
@yangm97

This comment has been minimized.

Copy link

yangm97 commented Jan 14, 2020

Gives me Habbo vibes...

@Sorunome Sorunome mentioned this pull request Jan 18, 2020
4 of 4 tasks complete
@Sorunome

This comment has been minimized.

Copy link
Contributor Author

Sorunome commented Jan 19, 2020

While implementing this in synapse soru noticed a few issues with the endpoints (that it simply wouldn't have worked the way it was originally outlined). Thus, this MSC has been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.