Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear up confusion between 'event.age' and 'event.unsigned.age' (SPEC-340) #630

Closed
matrixbot opened this issue Jan 27, 2016 · 1 comment
Closed

Clear up confusion between 'event.age' and 'event.unsigned.age' (SPEC-340) #630

matrixbot opened this issue Jan 27, 2016 · 1 comment
Labels
spec-bug Something which is in the spec, but is wrong
Projects
August 2018 r0

Comments

@matrixbot
Copy link
Member

Submitted by @​richvdh:matrix.org
event.age exists only for backwards compatibility, but many of the example responses still show it, and don't show event.unsigned at all.

(Imported from https://matrix.org/jira/browse/SPEC-340)
@matrixbot
Copy link
Member Author

Jira watchers: @richvdh

@matrixbot matrixbot changed the title Clear up confusion between 'event.age' and 'event.unsigned.age' Clear up confusion between 'event.age' and 'event.unsigned.age' (SPEC-340) Oct 31, 2016
@matrixbot matrixbot added the spec-bug Something which is in the spec, but is wrong label Nov 7, 2016
@turt2live turt2live added this to To do: client-server (prioritized) in August 2018 r0 Aug 14, 2018
@turt2live turt2live mentioned this issue Aug 16, 2018
Closed
@turt2live turt2live moved this from To do: client-server (prioritized) to In review (just the issues) in August 2018 r0 Aug 25, 2018
turt2live added a commit to turt2live/matrix-doc that referenced this issue Aug 25, 2018
@turt2live
Fix client-server event schemas: remove age, dedupe fields
0f28f83 
This commit adds support for event schema examples to have references to help reduce the chance of fields being forgotten. This also helps reduce duplication of fields, allowing for a more consistent spec that uses the same values everywhere.

This also removes both `unsigned` and `age` from the examples as per:
* matrix-org#1524
* matrix-org#630

Finally, this replaces "localhost" in the examples with an example domain. This is really just a nitpick thing on my part where seeing a "real world" domain is preferred. 

Fixes matrix-org#1524
Fixes matrix-org#630
Step towards https://github.com/matrix-org/matrix-doc/issues/1530
@turt2live turt2live mentioned this issue Aug 25, 2018
Merged
August 2018 r0 automation moved this from In review (just the issues) to Done (this list will be incomplete) Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec-bug Something which is in the spec, but is wrong
Projects
No open projects
August 2018 r0
  
Done (this list will be incomplete)
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matrixbot