event examples include spurious 'age' field #1524
Labels
spec-bug
Something which is in the spec, but is wrong
Projects
Comments
|
related: #684 |
|
The |
|
Related: #1294 |
turt2live
moved this from To do (general backlog)
to To do: client-server (prioritized)
in August 2018 r0
turt2live
added a commit
to turt2live/matrix-doc
that referenced
this issue
Aug 23, 2018
Fixes matrix-org#1269 This is also supposed to fix the 'age' problem, however that is a larger problem with the event schemas that is reserved for a future PR/commit. Reference: matrix-org#1294 Reference: matrix-org#1524
turt2live
moved this from To do: client-server (prioritized)
to In review (just the issues)
in August 2018 r0
turt2live
added a commit
to turt2live/matrix-doc
that referenced
this issue
Aug 25, 2018
This commit adds support for event schema examples to have references to help reduce the chance of fields being forgotten. This also helps reduce duplication of fields, allowing for a more consistent spec that uses the same values everywhere. This also removes both `unsigned` and `age` from the examples as per: * matrix-org#1524 * matrix-org#630 Finally, this replaces "localhost" in the examples with an example domain. This is really just a nitpick thing on my part where seeing a "real world" domain is preferred. Fixes matrix-org#1524 Fixes matrix-org#630 Step towards https://github.com/matrix-org/matrix-doc/issues/1530
turt2live
added a commit
to turt2live/matrix-doc
that referenced
this issue
Aug 29, 2018
This is useful for a lot of things, like bridges (appservices), VoIP handling, and clients which generally may wish to do something with the field. Might as well include it on every event, despite the recommendation of matrix-org#1524
August 2018 r0
automation
moved this from In review (just the issues)
to Done (this list will be incomplete)
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
most of the event examples include an
agefield, which isn't really part of the event - in particular it will be absent over federation./syncand/messageswill add anage, but put it in theunsignedobject./intialSyncprobably does put anagewhere the examples suggest, but it's deprecated.The example for m.room.redaction puts
ageunderunsigned, but I'm not sure that's very clear either.Basically I think we should remove both
ageandunsignedfrom these examples.The text was updated successfully, but these errors were encountered: