Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that application services receive events in the CSAPI format #1552

Merged
merged 4 commits into from
Aug 28, 2018

Conversation

turt2live
Copy link
Member

Rendered: see 'docs' status check.

It may be best to review this PR commit-by-commit.


Part of #1532
Fixes #1269

This is also supposed to fix the 'age' problem, however that is a larger problem with the event schemas that is reserved for a future PR/commit.
Reference: #1294
Reference: #1524

Fixes matrix-org#1269

This is also supposed to fix the 'age' problem, however that is a larger problem with the event schemas that is reserved for a future PR/commit.
Reference: matrix-org#1294
Reference: matrix-org#1524
@turt2live turt2live requested a review from a team August 23, 2018 19:33
@turt2live turt2live added this to In review in August 2018 r0 via automation Aug 23, 2018
@Half-Shot Half-Shot mentioned this pull request Aug 23, 2018
11 tasks
August 2018 r0 automation moved this from In review (just the PRs) to Reviewer approved Aug 27, 2018
Copy link
Member

@ara4n ara4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. nice that swagger lets you do that.

This commit has approval under matrix-org#1555 although is being included in this branch/PR so the build passes, permitting a merge.
@turt2live turt2live merged commit bba76c2 into matrix-org:master Aug 28, 2018
August 2018 r0 automation moved this from Reviewer approved to Done (this list will be incomplete) Aug 28, 2018
@turt2live turt2live deleted the travis/as/normal-events branch August 28, 2018 00:00
RiotTranslateBot pushed a commit to RiotTranslateBot/matrix-doc that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
August 2018 r0
  
Done (this list will be incomplete)
Development

Successfully merging this pull request may close these issues.

AppServices: Why do events sent to AS's use "user_id", whereas events use "sender"
2 participants