MSC1721: Rename m.login.cas to m.login.sso#1721
Conversation
richvdh
changed the title
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
generally seems straightforward to me. I assume implementations are recommended to support the CAS endpoints for now, and to advertise CAS and SSO login stages until clients can be reasonably updated.
| `/_matrix/client/r0/login/cas/redirect`: they should issue a redirect to | ||
| their configured single-sign-on system. | ||
|
|
||
| 4. Servers should probably rename the post-authentication callback endpoint |
There was a problem hiding this comment.
I've actually removed this section altogether. The server's behaviour needs to be completely different depending on whether it's handling a CAS or a SAML response, so it makes sense to leave it as /login/cas/ticket for a CAS response.
|
|
||
| 1. `m.login.sso` should be defined as a valid login type for return from `GET | ||
| /login`. (We should probably mention `m.login.cas` in the spec while we are | ||
| there). |
There was a problem hiding this comment.
Will it return m.long.sso along with m.login.cas or instead of it? I'd probably recommend "along" for the transition period (but I'd really be interested to know how many clients are even watching for m.login.cas - probably there's nothing worth discussing).
There was a problem hiding this comment.
s/m.long.sso/m.login.sso
There was a problem hiding this comment.
yup think it's best to return both for now.
riot-web has some very rudimentary support for m.login.cas, but that's it afaik
|
This doesn't seem terribly contentious. @mscbot fcp merge |
|
Team member @richvdh has proposed to merge this. The next step is review by the rest of the tagged teams: No concerns currently listed. Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
mscbot
added
proposed-final-comment-period
mscbot
added
final-comment-period
and removed
proposed-final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
richvdh
added
spec-pr-missing
|
this is implemented in matrix-org/matrix-react-sdk#2279 and matrix-org/synapse#4220 |
|
gah, very annoying that deleting the branch removes the rendered URL from the MSC: https://github.com/matrix-org/matrix-doc/blob/rav/proposal/sso_login/proposals/1721-rename-cas-to-sso.md I'm going to hit the restore button if that's ok |
|
doh. though now that this has merged it might make more sense to change the link to point to master. |
turt2live
added
spec-pr-in-review
turt2live
added
merged
|
Merged 🎉 Spec PR was #1789 |
7 participants
Rendered