Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2077: room v5 #2077

Merged
merged 3 commits into from
Jun 10, 2019
Merged

MSC2077: room v5 #2077

merged 3 commits into from
Jun 10, 2019

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jun 4, 2019

@richvdh richvdh added the proposal A matrix spec change proposal label Jun 4, 2019
@richvdh
Copy link
Member Author

richvdh commented Jun 4, 2019

In the hope that this is relatively uncontentious:

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Jun 4, 2019

Team member @richvdh has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Jun 4, 2019
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

proposals/2077-rooms-v5.md Outdated Show resolved Hide resolved
proposals/2077-rooms-v5.md Outdated Show resolved Hide resolved
@mscbot mscbot added the final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. label Jun 5, 2019
@mscbot
Copy link
Collaborator

mscbot commented Jun 5, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot removed the proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. label Jun 5, 2019
richvdh added a commit to matrix-org/synapse that referenced this pull request Jun 5, 2019
@turt2live turt2live self-assigned this Jun 5, 2019
turt2live added a commit that referenced this pull request Jun 5, 2019
Proposals:
* [MSC2076](#2076)
* [MSC2077](#2077)

Implementation references:
* matrix-org/synapse@00bf99f
* matrix-org/synapse#5354
* matrix-org/synapse#5321

No known differences from the proposals are included here - alterations are accidental.
@turt2live turt2live added the spec-pr-in-review A proposal which has been PR'd against the spec and is in review label Jun 5, 2019
@turt2live
Copy link
Member

Spec PR: #2080 (for when this clears FCP)

@mscbot
Copy link
Collaborator

mscbot commented Jun 10, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot removed the final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. label Jun 10, 2019
@turt2live turt2live merged commit 19575eb into master Jun 10, 2019
@turt2live
Copy link
Member

merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jun 11, 2019
@turt2live turt2live added the kind:core MSC which is critical to the protocol's success label Apr 20, 2020
@afranke afranke deleted the rav/proposal/room_v5 branch September 22, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge kind:core MSC which is critical to the protocol's success merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants