Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2214: Joining upgraded private rooms #2214

Open
wants to merge 3 commits into
base: old_master
Choose a base branch
from

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Aug 2, 2019

@ara4n
Copy link
Member

ara4n commented Aug 2, 2019

disappointing

@turt2live turt2live changed the title [WIP] MSC2214: Joining upgraded private rooms MSC2214: Joining upgraded private rooms Aug 2, 2019
@turt2live turt2live added proposal A matrix spec change proposal proposal-in-review labels Aug 2, 2019
@turt2live
Copy link
Member Author

@ara4n and now? 😇

@turt2live turt2live marked this pull request as ready for review August 2, 2019 22:37
@ara4n
Copy link
Member

ara4n commented Aug 2, 2019

much better ;)

in terms of the actual MSC: it's probably an obvious question, but: why clone over as m.room.previous_member events at all? why not make them m.room.members?

@turt2live
Copy link
Member Author

turt2live commented Aug 2, 2019

Because of https://github.com/matrix-org/matrix-doc/pull/2214/files#diff-3ca6ba2dd370c7a964783f11e300128eR107-R111

The TLDR is that the auth rules get difficult because we can't really do auth rules across multiple rooms yet, so it would be possible for someone to craft a room which automatically joins everyone.

Edit: and as for just spamming invites: this is also mentioned in the proposal as undesirable notifications.

@@ -0,0 +1,126 @@
# Joining upgraded private rooms
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Incorporate this rationale into the proposal somewhere (and surrounding discussion)

fwiw the overarching idea is that servers just attempt to join rooms and expect it to fail, rather than have them spend a bunch of time adding if statements for suppressing notifications (which would also need to be added to every client), handling the invite differently, etc. It puts the burden of figuring out if a user can join on the server which did the upgrade (and any other resident servers after the fact), letting the client implementations need no changes.

@turt2live turt2live added the unassigned-room-version Remove this label when things get versioned. label Aug 6, 2019
@turt2live turt2live added the kind:feature MSC for not-core and not-maintenance stuff label Apr 20, 2020
@turt2live turt2live added requires-room-version An idea which will require a bump in room version and removed unassigned-room-version Remove this label when things get versioned. labels Apr 6, 2021
@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal requires-room-version An idea which will require a bump in room version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants