-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC2214: Joining upgraded private rooms #2214
base: old_master
Are you sure you want to change the base?
Conversation
disappointing |
@ara4n and now? 😇 |
much better ;) in terms of the actual MSC: it's probably an obvious question, but: why clone over as |
The TLDR is that the auth rules get difficult because we can't really do auth rules across multiple rooms yet, so it would be possible for someone to craft a room which automatically joins everyone. Edit: and as for just spamming invites: this is also mentioned in the proposal as undesirable notifications. |
@@ -0,0 +1,126 @@ | |||
# Joining upgraded private rooms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Incorporate this rationale into the proposal somewhere (and surrounding discussion)
fwiw the overarching idea is that servers just attempt to join rooms and expect it to fail, rather than have them spend a bunch of time adding if statements for suppressing notifications (which would also need to be added to every client), handling the invite differently, etc. It puts the burden of figuring out if a user can join on the server which did the upgrade (and any other resident servers after the fact), letting the client implementations need no changes.
Rendered
Related issues: