[WIP] MSC2300: /ping endpoint#2300
Draft
ara4n wants to merge 1 commit into
Draft
Conversation
Member
Author
|
#2301 is an example of why we shouldn't be using /versions as a ping endpoint. |
turt2live
requested changes
Sep 24, 2019
|
|
||
| ## Proposal | ||
|
|
||
| Currently there is no well-defined way for clients to determine whether their server is still alive and well. |
Member
There was a problem hiding this comment.
why can't they check /sync or other errors? Do we really need a ping endpoint given HTTP has very well-defined errors?
Riot only uses /versions because it got an error on /sync, which it feels is a server problem and therefore tries to reinitialize itself. Hitting /versions on loop is one way of doing this and is a lighter endpoint if there are server performance problems. Theory is, I believe, that when the server starts throwing errors at you it is likely being updated or has its config changed: if it suddenly supports r0.6 then why not use that?
turt2live
added
the
needs-implementation
Member
|
Related: #3360 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is no well-defined way for clients to determine whether their server is still alive and well.
Riot/Web fudges this by calling /versions, but this is an abuse (especially if & when /versions becomes a richer endpoint).
Enter /ping instead.
Rendered