Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2334 - Change default room version to v5 #2334

Merged
merged 2 commits into from
Nov 5, 2019
Merged

MSC2334 - Change default room version to v5 #2334

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6270983
MSC2334 - Change default room version to v5
aaronraimist Oct 30, 2019
14c32cc
Wrap lines
aaronraimist Oct 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions proposals/2334-default-room-version-v5.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# MSC2334 - Change default room version to v5

This MSC proposes changing the recommended default room version from v4 to v5. This implements steps 5 and 6 of the plan from [MSC2002](https://github.com/matrix-org/matrix-doc/issues/2002).
aaronraimist marked this conversation as resolved.
Show resolved Hide resolved

Room version 5 enforces the `valid_until_ts` timestamp on signing keys as proposed in [MSC2076](https://github.com/matrix-org/matrix-doc/issues/2076).

## Proposal

When [MSC2077](https://github.com/matrix-org/matrix-doc/issues/2077) proposed room version 5, the default version continued to be v4 to allow old servers to continue to chat in newly created rooms. Server-Server API r0.1.2 (which contains the details on room version 5) and Synapse 1.0.0 (with support for room version 5) were both released more than 4 months ago which has given people plenty of time to update. Room version 5 should be the default room version so that newly created rooms enforce key-validity periods.

## Potential issues

Servers which do not support room version 5 will not be able to participate in newly created rooms on other servers. Hopefully this will encourage them to update their server.

## Security considerations

Room version 5 fixes known security vulnerabilities but that doesn't do much good if newly created rooms aren't using room version 5 by default.