Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2334 - Change default room version to v5 #2334

Merged
merged 2 commits into from
Nov 5, 2019
Merged

MSC2334 - Change default room version to v5 #2334

merged 2 commits into from
Nov 5, 2019

Conversation

aaronraimist
Copy link
Contributor

@aaronraimist aaronraimist commented Oct 30, 2019 •
edited
Loading

@aaronraimist aaronraimist changed the title MSC2333 - Change default room version to v5 MSC2334 - Change default room version to v5 Oct 30, 2019
@aaronraimist aaronraimist force-pushed the MSC2333-default-room-version-v5 branch from d633007 to f61b547 Compare October 30, 2019 19:39
@aaronraimist
MSC2334 - Change default room version to v5
6270983 
Signed-off-by: Aaron Raimist <aaron@raim.ist>
@aaronraimist aaronraimist force-pushed the MSC2333-default-room-version-v5 branch from f61b547 to 6270983 Compare October 30, 2019 19:41
@aaronraimist aaronraimist mentioned this pull request Oct 30, 2019
Closed
@turt2live turt2live added proposal A matrix spec change proposal proposal-in-review labels Oct 30, 2019
turt2live
turt2live approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall seems very sensible to me - it has indeed been long enough.

proposals/2334-default-room-version-v5.md Outdated Show resolved Hide resolved
@turt2live
Copy link
Member

thanks!

This is fairly straightforward and is in fact the plan we agreed upon before, so:

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Oct 30, 2019 •
edited by dbkr
Loading

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once at least 75% of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Oct 30, 2019
@mscbot
Copy link
Collaborator

mscbot commented Oct 31, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added finished-final-comment-period and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Oct 31, 2019
@mscbot
Copy link
Collaborator

mscbot commented Nov 5, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@turt2live turt2live merged commit fed0b95 into matrix-org:master Nov 5, 2019
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed finished-final-comment-period labels Nov 5, 2019
turt2live added a commit that referenced this pull request Nov 5, 2019
@turt2live
Make room version 5 the default room version.
3e035c9 
As per [MSC2334](#2334)
@turt2live turt2live mentioned this pull request Nov 5, 2019
Merged
@turt2live
Copy link
Member

Spec PR: #2347

@aaronraimist aaronraimist deleted the MSC2333-default-room-version-v5 branch November 5, 2019 23:15
@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Nov 5, 2019
@turt2live
Copy link
Member

Merged 🎉

@turt2live turt2live added kind:core MSC which is critical to the protocol's success kind:maintenance MSC which clarifies/updates existing spec and removed kind:core MSC which is critical to the protocol's success labels Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
disposition-merge kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronraimist @turt2live @mscbot