Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2457: Invalidating devices during password modification #2457

Merged
merged 4 commits into from
May 2, 2020
Merged

MSC2457: Invalidating devices during password modification #2457

merged 4 commits into from
May 2, 2020

Conversation

clokep
Copy link
Contributor

@clokep clokep commented Mar 12, 2020 •
edited
Loading

@clokep clokep force-pushed the clokep/modify-password-invalid-sessions branch from 37e695a to 1facf7f Compare March 12, 2020 19:00
@clokep clokep changed the title Invalidating devices during password modification MSC2457: Invalidating devices during password modification Mar 12, 2020
@clokep clokep added proposal A matrix spec change proposal proposal-in-review labels Mar 12, 2020
@clokep clokep marked this pull request as ready for review March 12, 2020 19:01
@turt2live turt2live self-requested a review March 12, 2020 19:07
This was referenced Mar 16, 2020
Merged
Merged
anoadragon453
anoadragon453 approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

proposals/2457-password-modification-invalidating-devices.md Outdated Show resolved Hide resolved
@clokep @anoadragon453
Remove duplicated word.
2d2731e 
Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@richvdh richvdh self-requested a review March 16, 2020 22:40
@richvdh richvdh mentioned this pull request Mar 16, 2020
Closed
richvdh
richvdh approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple and effective.

@richvdh
Copy link
Member

richvdh commented Mar 19, 2020

@mscbot fcp merge

@richvdh richvdh added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. and removed proposal-in-review labels Mar 19, 2020
@richvdh
Copy link
Member

richvdh commented Mar 19, 2020 •
edited by anoadragon453
Loading

(this is implemented in matrix-org/synapse#7085)

@matrix-org matrix-org deleted a comment from richvdh Mar 19, 2020
@mscbot
Copy link
Collaborator

mscbot commented Mar 19, 2020 •
edited by turt2live
Loading

Team member @richvdh has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

None listed.

@ara4n ara4n mentioned this pull request Mar 31, 2020
Closed
@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Apr 20, 2020
@matrix-org matrix-org deleted a comment from mscbot Apr 27, 2020
@turt2live
Copy link
Member

Looks like @mscbot is stuck, so manually starting the process here.

Per the checkboxes above this MSC has entered final comment period.

@turt2live turt2live added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Apr 27, 2020
@turt2live
Copy link
Member

Per the review above this has finished final comment period!

@turt2live turt2live merged commit 8ba6d01 into master May 2, 2020
@turt2live turt2live added finished-final-comment-period spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. finished-final-comment-period labels May 2, 2020
@clokep clokep deleted the clokep/modify-password-invalid-sessions branch May 4, 2020 11:34
@anoadragon453 anoadragon453 restored the clokep/modify-password-invalid-sessions branch May 4, 2020 17:06
@clokep clokep deleted the clokep/modify-password-invalid-sessions branch May 4, 2020 17:27
@clokep clokep restored the clokep/modify-password-invalid-sessions branch May 4, 2020 17:27
@clokep clokep mentioned this pull request May 4, 2020
Merged
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review merged A proposal whose PR has merged into the spec! and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels May 4, 2020
@turt2live
Copy link
Member

Merged 🎉

Spec PR was #2523

@jplatte jplatte mentioned this pull request Jun 5, 2020
Closed
19 tasks
@clokep clokep mentioned this pull request May 13, 2021
Draft
@clokep clokep deleted the clokep/modify-password-invalid-sessions branch May 17, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhoreg uhoreg uhoreg left review comments

@turt2live turt2live turt2live approved these changes

@anoadragon453 anoadragon453 anoadragon453 approved these changes

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
disposition-merge kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@clokep @richvdh @mscbot @turt2live @uhoreg @anoadragon453