Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2457: Invalidating devices during password modification #2457

Merged
merged 4 commits into from May 2, 2020

Conversation

clokep
Copy link
Member

@clokep clokep commented Mar 12, 2020

@clokep clokep force-pushed the clokep/modify-password-invalid-sessions branch from 37e695a to 1facf7f Compare Mar 12, 2020
@clokep clokep changed the title Invalidating devices during password modification MSC2457: Invalidating devices during password modification Mar 12, 2020
@clokep clokep added proposal proposal-in-review labels Mar 12, 2020
@clokep clokep marked this pull request as ready for review Mar 12, 2020
@turt2live turt2live self-requested a review Mar 12, 2020
Copy link
Member

@anoadragon453 anoadragon453 left a comment

lgtm

Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Copy link
Member

@richvdh richvdh left a comment

simple and effective.

@richvdh
Copy link
Member

@richvdh richvdh commented Mar 19, 2020

@mscbot fcp merge

@richvdh richvdh added proposed-final-comment-period and removed proposal-in-review labels Mar 19, 2020
@richvdh
Copy link
Member

@richvdh richvdh commented Mar 19, 2020

(this is implemented in matrix-org/synapse#6976)

@matrix-org matrix-org deleted a comment from richvdh Mar 19, 2020
@mscbot
Copy link
Collaborator

@mscbot mscbot commented Mar 19, 2020

Team member @richvdh has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

None listed.

@turt2live
Copy link
Member

@turt2live turt2live commented Apr 27, 2020

Looks like @mscbot is stuck, so manually starting the process here.

Per the checkboxes above this MSC has entered final comment period.

@turt2live turt2live added final-comment-period and removed proposed-final-comment-period labels Apr 27, 2020
@turt2live
Copy link
Member

@turt2live turt2live commented May 2, 2020

Per the review above this has finished final comment period!

@turt2live turt2live merged commit 8ba6d01 into master May 2, 2020
8 checks passed
@turt2live turt2live added finished-final-comment-period spec-pr-missing and removed final-comment-period finished-final-comment-period labels May 2, 2020
@clokep clokep deleted the clokep/modify-password-invalid-sessions branch May 4, 2020
@anoadragon453 anoadragon453 restored the clokep/modify-password-invalid-sessions branch May 4, 2020
@clokep clokep deleted the clokep/modify-password-invalid-sessions branch May 4, 2020
@clokep clokep restored the clokep/modify-password-invalid-sessions branch May 4, 2020
@turt2live turt2live added spec-pr-in-review merged and removed spec-pr-missing spec-pr-in-review labels May 4, 2020
@turt2live
Copy link
Member

@turt2live turt2live commented May 4, 2020

Merged 🎉

Spec PR was #2523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge kind:maintenance merged proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants