MSC2625: Add mark_unread push rule action
#2625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 10, 2020
|
Synapse implementation: matrix-org/synapse#7673 |
ara4n
reviewed
Jun 10, 2020
ara4n
reviewed
Jun 10, 2020
Co-authored-by: Matthew Hodgson <matthew@matrix.org>
babolivier
added a commit
to matrix-org/synapse
that referenced
this pull request
Jun 17, 2020
This was referenced Jun 23, 2020
turt2live
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
This feels a bit quicker to do, albeit risking further confusion and concern with the push rules system. It's a bit questionable to let users decide what counts as something worth marking as unread, and different clients may have different opinions on that anyways.
|
sorry, I should have said: this is being superceded by #2654. Trying to get both "unread" and "notifications" out of the same list of push rules was a nightmare. |
turt2live
added
abandoned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered