MSC3553: Extensible Events - Videos #3553
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
changed the title
turt2live
added
kind:core
| }, | ||
| "m.thumbnail": [ // optional | ||
| { | ||
| // A thumbnail is an m.file+m.image, or a small image |
There was a problem hiding this comment.
Suggested change
| // A thumbnail is an m.file+m.image, or a small image | |
| // A thumbnail is an m.file+m.image_details, or a small image |
| The above describes the minimum requirements for sending an `m.video` event. Senders can add additional | ||
| blocks, however as per the extensible events system, receivers which understand video events should not | ||
| honour them. Such examples might include an `m.audio` block for "audio-only" mode (podcasts, etc) or | ||
| an `m.image` to represent the video as a GIF (or similar). |
There was a problem hiding this comment.
You say that an m.image content block could be included to represent a GIF here, though m.image isn't a content block. Did you mean m.file? I'm not sure how that would not collide with the m.file for m.video though.
There was a problem hiding this comment.
The words:
An image fallback is not necessarily possible, despite all the required blocks being possible.
are below though, which also makes me question this paragraph.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Blocked by #1767
Blocked by #3551
Blocked by #3552
Preview: https://pr3553--matrix-org-previews.netlify.app