Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] MSC3662: Allow Widgets to share user mxids to the client #3662

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[WIP] MSC3662: Allow Widgets to share user mxids to the client #3662

wants to merge 3 commits into from

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Jan 20, 2022 •
edited by github-actions bot
Loading

@Half-Shot Half-Shot changed the title MSC0000: Allow Widgets to share user mxids to the client [WIP] MSC0000: Allow Widgets to share user mxids to the client Jan 20, 2022
@Half-Shot Half-Shot changed the title [WIP] MSC0000: Allow Widgets to share user mxids to the client [WIP] MSC3662: Allow Widgets to share user mxids to the client Jan 20, 2022
turt2live
turt2live reviewed Jan 20, 2022
View reviewed changes
proposals/3662-widget-share-api.md Outdated
searching for users across the remote network, which can then invoke invites or room creation
on the remote side.

For sharing eventIds or rooms, this is somewhat covered by [MSC2931](https://github.com/matrix-org/matrix-doc/pull/2931/files)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSC2931 also covers user IDs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I suppose the lack of examples threw me. I'll amend.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2931 is a generic permalink routing solution, so would need to add ?action=chat and such to carry intent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that'd work 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm a bit confused as to what this MSC is proposing, then)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, 2931 didn't state userIds as being supported explicity nor the action=chat part so at the point of writing it wasn't very clear that the functionality was intended.

I suppose if that MSC were updated I could close this one though.

@turt2live turt2live marked this pull request as draft January 20, 2022 15:43
@turt2live turt2live added kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal widgets anything to do with widgets labels Jan 20, 2022
@Half-Shot Half-Shot mentioned this pull request Jan 21, 2022
Open
@ShadowJonathan ShadowJonathan mentioned this pull request Feb 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live left review comments

Assignees
No one assigned
Labels
kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal widgets anything to do with widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @turt2live