Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unenforced size limit on room names #3669

Merged
merged 3 commits into from
Feb 22, 2022
Merged

Remove unenforced size limit on room names #3669

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6881a01
Remove unenforced size limit on room names
aaronraimist Jan 23, 2022
ba0f1a1
Add changelog
aaronraimist Jan 23, 2022
9cacb4c
Switch from breaking to clarification
aaronraimist Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/client_server/newsfragments/3669.breaking
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove unenforced size limit on the `name` field of `m.room.name` events.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given we're making this change on the basis that it has never been enforced, this is a clarification rather than a .breaking imho

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I have switched it to a clarification.

2 changes: 1 addition & 1 deletion data/event-schemas/schema/m.room.name.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ properties:
content:
properties:
name:
description: The name of the room. This MUST NOT exceed 255 bytes.
description: The name of the room.
type: string
required:
- name
Expand Down