Conversation
Signed-off-by: Robin Townsend <robin@robin.town>
robintown
force-pushed
the
content-warnings
branch
from
1a23268 to
773cf56
Compare
turt2live
added
client-server
|
Any news on this? |
|
What this needs next is an implementation. Anyone is welcome to provide one :) |
| and replacing the content warning types `m.spoiler`, `m.nsfw`, `m.graphic`, and | ||
| `m.medical` with `town.robin.msc3725.spoiler`, `town.robin.msc3725.nsfw`, | ||
| `town.robin.msc3725.graphic`, and `town.robin.msc3725.medical` respectively. |
There was a problem hiding this comment.
Not really sure if we need to use unstable prefixes for the warning types, since it's already within an unstable field.
There was a problem hiding this comment.
unstable prefixes are required here because the meanings could change still, and developers will need to then do slightly more complicated lookups/matching. For example, if m.nsfw changed scope, the unstable implementation may need to create a whole new field instead of a town.robin.msc3725.nsfw.v2 type.
| which are just one of the many event types that might require some kind of | ||
| content warning (images, videos, files, etc.). This MSC proposes a more general | ||
| content warning system to fill that gap, using | ||
| [Extensible Events](https://github.com/matrix-org/matrix-doc/pull/1767) to |
There was a problem hiding this comment.
From what I can tell, there's not really any reason this is dependent on extensible events. We can just as easily add the m.content_warning field to normal events (similar to what we did with m.mentions.
There was a problem hiding this comment.
I agree that the extensible events dependency should be dropped.
@robintown do you have time to update the MSC? If not, I can also make the changes (and probably implement this in gomuks web)
There was a problem hiding this comment.
Here is a (probably bad) implementation of this MSC in gomuks web: gomuks/gomuks#533
| content warning, clients can then take measures to require consent from the user | ||
| before displaying the content. | ||
|
|
||
| ## Proposal |
There was a problem hiding this comment.
Currently, this proposal allows for both the type and description to be unspecified, which doesn't make sense. I think that we should require at least one to be specified.
| ``` | ||
|
|
||
| The `type` field is optional, and represents the general, machine-readable | ||
| reason for the content warning. The following types are provided: |
There was a problem hiding this comment.
Maybe mention here that there can be other values (as long as they have unstable prefixes).
|
Any news on this? |
9 participants
Rendered
Supersedes MSC3286: Media spoilers.
Depends on MSC1767: Extensible Events.
Closes https://github.com/matrix-org/matrix-doc/issues/548.
Closes https://github.com/matrix-org/matrix-doc/issues/604.
Preview: https://pr3725--matrix-org-previews.netlify.app