Skip to content

MSC3783: Fixed base64 for SAS verification#3783

Merged
turt2live merged 4 commits into
matrix-org:mainfrom
uhoreg:sas_fixed_base64
Jan 9, 2023
Merged

MSC3783: Fixed base64 for SAS verification#3783
turt2live merged 4 commits into
matrix-org:mainfrom
uhoreg:sas_fixed_base64

Conversation

@uhoreg

@uhoreg uhoreg commented Apr 25, 2022 •
edited by turt2live
Loading

Copy link
Copy Markdown
Member

@uhoreg uhoreg changed the title MSCxxxx: Fixed base64 for SAS verification MSC3783: Fixed base64 for SAS verification Apr 25, 2022
@uhoreg uhoreg mentioned this pull request Apr 25, 2022
Merged
@uhoreg uhoreg marked this pull request as ready for review April 25, 2022 15:17
poljar
poljar reviewed Apr 25, 2022
View reviewed changes
Comment thread proposals/3783-fixed-base64-sas-verification.md Outdated
@uhoreg uhoreg added A-Encryption E2EE proposal-in-review proposal A matrix spec change proposal. Process state. A-Client Server Client-Server API kind:maintenance MSC which clarifies/updates existing spec labels Apr 25, 2022
@poljar poljar mentioned this pull request Apr 25, 2022
Closed
This was referenced Apr 26, 2022
Open
Open
Closed
richvdh
richvdh reviewed Dec 6, 2022
View reviewed changes
Comment thread proposals/3783-fixed-base64-sas-verification.md Outdated
@uhoreg

uhoreg commented Dec 21, 2022

Copy link
Copy Markdown
Member Author

@mscbot fcp merge

@mscbot

mscbot commented Dec 21, 2022 •
edited by richvdh
Loading

Copy link
Copy Markdown
Collaborator

Team member @uhoreg has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge Process state. proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the FCP. Process state. labels Dec 21, 2022
richvdh
richvdh reviewed Jan 3, 2023
View reviewed changes
Comment thread proposals/3783-fixed-base64-sas-verification.md
@mscbot

mscbot commented Jan 4, 2023

Copy link
Copy Markdown
Collaborator

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period Process state to accept, reject, or postpone an MSC. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the FCP. Process state. labels Jan 4, 2023
@mscbot

mscbot commented Jan 9, 2023

Copy link
Copy Markdown
Collaborator

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot removed disposition-merge Process state. final-comment-period Process state to accept, reject, or postpone an MSC. labels Jan 9, 2023
@mscbot mscbot added the finished-final-comment-period FCP has finished. Process state. label Jan 9, 2023
@turt2live turt2live merged commit 9b3f01b into matrix-org:main Jan 9, 2023
@turt2live turt2live added spec-pr-missing MSC is accepted, but missing spec PR. Process state. and removed finished-final-comment-period FCP has finished. Process state. labels Jan 9, 2023
@uhoreg uhoreg mentioned this pull request Jan 24, 2023
Merged
@uhoreg

uhoreg commented Jan 24, 2023

Copy link
Copy Markdown
Member Author

Spec PR: matrix-org/matrix-spec#1412

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing MSC is accepted, but missing spec PR. Process state. labels Jan 25, 2023
@uhoreg uhoreg mentioned this pull request Jan 25, 2023
Merged
3 tasks
@uhoreg uhoreg added merged A proposal whose PR has merged into the spec! Process state. and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Feb 10, 2023
@uhoreg

uhoreg commented Feb 10, 2023

Copy link
Copy Markdown
Member Author

merged! 🎉

@zecakeh zecakeh mentioned this pull request Feb 10, 2023
Closed
34 tasks
@clokep clokep mentioned this pull request Feb 17, 2023
Closed
8 tasks
@KitsuneRal KitsuneRal mentioned this pull request Apr 16, 2023
Merged
@td-famedly td-famedly mentioned this pull request Dec 6, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poljar poljar poljar left review comments

@richvdh richvdh richvdh left review comments

Assignees

No one assigned

Labels

A-Client Server Client-Server API A-Encryption E2EE kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! Process state. proposal A matrix spec change proposal. Process state.

Projects

Spec Core Team Workflow
Status: Merged/Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@uhoreg @mscbot @poljar @richvdh @turt2live