Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] MSC3865: User-given attributes for users #3865

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Zocker1999NET
Copy link

@Zocker1999NET Zocker1999NET commented Aug 9, 2022

Signed-off-by: Felix Stupp felix.stupp+github@banananet.work

@Zocker1999NET Zocker1999NET changed the title [WIP] MSCXXXX: User-given attributes for users [WIP] MSC3865: User-given attributes for users Aug 9, 2022
Zocker1999NET added a commit to Zocker1999NET/matrix-spec-proposals that referenced this pull request Aug 9, 2022
user's user-given attributes now defined in
[MSC3865](matrix-org#3865)
@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Aug 9, 2022
@dklimpel
Copy link
Contributor

Related to:

@Mart-Bogdan
Copy link

As I understend size of single item in User Config is limited at 64 KiB

https://matrix.to/#/!NasysSDfxKxZBzJJoE:matrix.org/$ArNvLz_XK2CoXVb64g99ns6o-8DYIbDz0Ze_6NXMBaI?via=matrix.org&via=envs.net&via=element.io

So it can be an issue if somebody store too much data in m.user_given.user.description

Perhaps we need to store data for each user individually? like m.user_given.@alice:example.com.description.

Sadly it would explode amount of user data stored, IDK if this can cause problems.

Other option is to create m.user_given.user.description.2 when first one run out of storage.

@tusooa
Copy link
Contributor

tusooa commented Jun 7, 2024

Just so you know, I am implementing this in kazv: https://iron.lily-is.land/T77

@tusooa
Copy link
Contributor

tusooa commented Jul 14, 2024

As this is done in kazv ( https://iron.lily-is.land/T77 ) I think we should remove the needs-implementation label.

@uhoreg uhoreg added implementation-needs-checking The MSC has an implementation, but the SCT has not yet checked it. and removed needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Jul 17, 2024
### Implementation

For each attribute of a user profile, a new event type shall be defined.
To get the new event type, the prefix `m.user_given.user.` shall be appended to the attribute's name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To get the new event type, the prefix `m.user_given.user.` shall be appended to the attribute's name.
To get the new event type, the prefix `m.user_given.user.` shall be prepended to the attribute's name.

is more appropriate, since it goes at the beginning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API implementation-needs-checking The MSC has an implementation, but the SCT has not yet checked it. kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants