-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC3938: Remove keyId from /keys
endpoints
#3938
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
@mscbot fcp merge |
Team member @richvdh has proposed to merge this. The next step is review by the rest of the tagged people: Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for information about what commands tagged team members can give me. |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period, with a disposition to merge, as per the review above, is now complete. |
Spec PR is matrix-org/matrix-spec#1350 |
Merged 🎉 |
This is a breaking change: some servers (such as Synapse, until [very | ||
recently](https://github.com/matrix-org/synapse/pull/14525)) may include the | ||
`{keyId}` in outgoing requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked a bit about this in the synapse issue for how to support Matrix v1.6: matrix-org/synapse#15089 (comment)
The `keyId` path parameter on | ||
[`GET /_matrix/key/v2/server/{keyId}`](https://spec.matrix.org/v1.5/server-server-api/#get_matrixkeyv2serverkeyid) | ||
and [`GET /_matrix/key/v2/query/{serverName}/{keyId}`](https://spec.matrix.org/v1.5/server-server-api/#get_matrixkeyv2queryservernamekeyid) | ||
has been deprecated since before the Matrix spec was formally versioned | ||
([pull request](https://github.com/matrix-org/matrix-spec-proposals/pull/1423)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't explicitly called out, but I assume POST /_matrix/key/v2/query
is unchanged by this MSC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. That does not take a keyId
parameter.
Rendered
matrix-org/synapse#14525 demonstrates Synapse working without this endpoint.