MSC3938: Remove keyId from /keys endpoints
#3938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
added
s2s
This comment was marked as duplicate.
This comment was marked as duplicate.
turt2live
reviewed
Nov 22, 2022
richvdh
removed
the
needs-implementation
|
@mscbot fcp merge |
|
Team member @richvdh has proposed to merge this. The next step is review by the rest of the tagged people: Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for information about what commands tagged team members can give me. |
mscbot
added
disposition-merge
proposed-final-comment-period
turt2live
added this to Needs idea feedback / initial review
in Spec Core Team Backlog
via automation
turt2live
moved this from Needs idea feedback / initial review
to Ready for FCP ticks
in Spec Core Team Backlog
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
mscbot
added
final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
mscbot
added
finished-final-comment-period
and removed
disposition-merge
final-comment-period
turt2live
added
spec-pr-missing
turt2live
added
spec-pr-in-review
turt2live
moved this from Requires spec writing
to Requires spec PR review
in Spec Core Team Backlog
|
Spec PR is matrix-org/matrix-spec#1350 |
|
Merged 🎉 |
turt2live
moved this from Requires spec PR review
to Done to some definition
in Spec Core Team Backlog
turt2live
added
merged
This was referenced Jan 3, 2023
8 tasks
clokep
reviewed
May 1, 2023
Comment on lines
+27
to
+29
| This is a breaking change: some servers (such as Synapse, until [very | ||
| recently](https://github.com/matrix-org/synapse/pull/14525)) may include the | ||
| `{keyId}` in outgoing requests. |
There was a problem hiding this comment.
We talked a bit about this in the synapse issue for how to support Matrix v1.6: matrix-org/synapse#15089 (comment)
clokep
reviewed
May 1, 2023
Comment on lines
+3
to
+7
| The `keyId` path parameter on | ||
| [`GET /_matrix/key/v2/server/{keyId}`](https://spec.matrix.org/v1.5/server-server-api/#get_matrixkeyv2serverkeyid) | ||
| and [`GET /_matrix/key/v2/query/{serverName}/{keyId}`](https://spec.matrix.org/v1.5/server-server-api/#get_matrixkeyv2queryservernamekeyid) | ||
| has been deprecated since before the Matrix spec was formally versioned | ||
| ([pull request](https://github.com/matrix-org/matrix-spec-proposals/pull/1423)). |
There was a problem hiding this comment.
It isn't explicitly called out, but I assume POST /_matrix/key/v2/query is unchanged by this MSC?
There was a problem hiding this comment.
Yes. That does not take a keyId parameter.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
matrix-org/synapse#14525 demonstrates Synapse working without this endpoint.